Users: Correct get_the_author_posts() to always return an integer.

This matches the documented `@return` type.

Follow-up to [5638], [13576], [36085], [60296].

Props justlevine.
See #63268.

git-svn-id: https://develop.svn.wordpress.org/trunk@60299 602fd350-edb4-49c9-b593-d223f7449a82

Author: SergeyBiryukov

src/wp-includes/author-template.php

@@ -286,7 +286,7 @@ function get_the_author_posts() {
 	if ( ! $post ) {
 		return 0;
 	}
-	return count_user_posts( $post->post_author, $post->post_type );
+	return (int) count_user_posts( $post->post_author, $post->post_type );
 }
 
 /**

tests/phpunit/tests/user/getTheAuthorPosts.php

@@ -42,7 +42,7 @@ public function test_get_the_author_posts() {
 		// Test with no global post, result should be 0 because no author is found.
 		$this->assertSame( 0, get_the_author_posts() );
 		$GLOBALS['post'] = self::$post_id;
-		$this->assertEquals( 1, get_the_author_posts() );
+		$this->assertSame( 1, get_the_author_posts() );
 	}
 
 	/**
@@ -60,7 +60,7 @@ public function test_get_the_author_posts_with_custom_post_type() {
 		);
 		$GLOBALS['post'] = $cpt_ids[0];
 
-		$this->assertEquals( 2, get_the_author_posts() );
+		$this->assertSame( 2, get_the_author_posts() );
 
 		_unregister_post_type( 'wptests_pt' );
 	}