Coding Standards: Remove extra empty() in request_filesystem_credentials().

SergeyBiryukov · SergeyBiryukov · commit d2613dae2865 · 2025-06-14T05:02:41.000Z
This commit removes an unnecessary `empty( $connection_type )` check, as the left side of the same conditional already accounts for a possibly empty value. Follow-up to [37467]. Props justlevine. See #63268. git-svn-id: https://develop.svn.wordpress.org/trunk@60309 602fd350-edb4-49c9-b593-d223f7449a82
diff --git a/src/wp-admin/includes/file.php b/src/wp-admin/includes/file.php
@@ -2622,7 +2622,7 @@ function request_filesystem_credentials( $form_post, $type = '', $error = false,
 	<?php
 	if ( isset( $types['ssh'] ) ) {
 		$hidden_class = '';
-		if ( 'ssh' !== $connection_type || empty( $connection_type ) ) {
+		if ( 'ssh' !== $connection_type ) {
 			$hidden_class = ' class="hidden"';
 		}
 		?>

Original file line number	Diff line number	Diff line change
`@@ -2622,7 +2622,7 @@ function request_filesystem_credentials( $form_post, $type = '', $error = false,`
`2622`	`2622`	`<?php`
`2623`	`2623`	`if ( isset( $types['ssh'] ) ) {`
`2624`	`2624`	`$hidden_class = '';`
`2625`		`- if ( 'ssh' !== $connection_type \|\| empty( $connection_type ) ) {`
	`2625`	`+ if ( 'ssh' !== $connection_type ) {`
`2626`	`2626`	`$hidden_class = ' class="hidden"';`
`2627`	`2627`	`}`
`2628`	`2628`	`?>`