adding unit testcases and modifying solution to check only drafts

Author: anukasha-mo

src/wp-includes/class-wp-query.php

@@ -1089,7 +1089,7 @@ public function parse_query( $query = '' ) {
 
 			if ( 'page' === get_option( 'show_on_front' ) && isset( $this->queried_object_id ) && get_option( 'page_for_posts' ) == $this->queried_object_id ) {
 				$posts_page = get_post( $this->queried_object_id );
-				if ( ! $posts_page || 'publish' !== $posts_page->post_status ) {
+				if ( ! $posts_page || 'draft' == $posts_page->post_status ) {
 					$this->set_404();
 					return;
 				}
@@ -1106,7 +1106,7 @@ public function parse_query( $query = '' ) {
 		if ( $query_vars['page_id'] ) {
 			if ( 'page' === get_option( 'show_on_front' ) && get_option( 'page_for_posts' ) == $query_vars['page_id'] ) {
 				$posts_page = get_post( $query_vars['page_id'] );
-				if ( ! $posts_page || 'publish' !== $posts_page->post_status ) {
+				if ( ! $posts_page || 'draft' == $posts_page->post_status ) {
 					$this->set_404();
 					return;
 				}

tests/phpunit/tests/query/pageOnFront.php

@@ -0,0 +1,50 @@
+<?php
+
+class pageOnFront extends WP_UnitTestCase {
+
+	private $posts_page_id;
+	public function set_up() {
+		parent::set_up();
+
+		update_option( 'show_on_front', 'page' );
+		$this->posts_page_id = self::factory()->post->create(
+			array(
+				'post_title' => 'blog-page',
+				'post_type'  => 'page',
+			)
+		);
+		update_option('page_for_posts', $this->posts_page_id);
+		update_option(
+			'page_on_front',
+			self::factory()->post->create(
+				array(
+					'post_title'   => 'front-page',
+					'post_type'    => 'page',
+					'post_content' => "Page 1\n<!--nextpage-->\nPage 2",
+				)
+			)
+		);
+	}
+
+	/**
+	 * Ensure unpublished posts page returns 404.
+	 *
+	 * @ticket 60566
+	 */
+	public function test_unpublished_posts_page_returns_404() {
+
+		wp_update_post( array(
+			'ID'          => $this->posts_page_id,
+			'post_status' => 'draft',
+		) );
+
+		$q = new WP_Query( array(
+			'pagename' => 'blog-page',
+		) );
+
+		$this->assertTrue(
+			$q->is_404(),
+			"Unpublished posts page with status should return 404"
+		);
+	}
+}