Media: Prevent fatal error if metadata is an array.

Check the data type of ID3 data on import before running `wp_kses_post` or `wp_kses_post_deep` to fix a fatal error thrown when attempting to run `wp_kses_post` on non-string content in PHP 8.2+.

Adds unit tests to verify.

Props sllimrovert, ankitkumarshah, rollybueno, wpfy, hmbashar, SirLouen, johnbillion, huzaifaalmesbah, sandeepdahiya, sourabhjain, poojapadamad, joedolson.
Fixes #63529.

git-svn-id: https://develop.svn.wordpress.org/trunk@61098 602fd350-edb4-49c9-b593-d223f7449a82

Author: joedolson

src/wp-admin/includes/media.php

@@ -3534,7 +3534,7 @@ function wp_add_id3_tag_data( &$metadata, $data ) {
 		if ( ! empty( $data[ $version ]['comments'] ) ) {
 			foreach ( $data[ $version ]['comments'] as $key => $list ) {
 				if ( 'length' !== $key && ! empty( $list ) ) {
-					$metadata[ $key ] = wp_kses_post( reset( $list ) );
+					$metadata[ $key ] = is_array( $list ) ? wp_kses_post_deep( reset( $list ) ) : wp_kses_post( $list );
 					// Fix bug in byte stream analysis.
 					if ( 'terms_of_use' === $key && str_starts_with( $metadata[ $key ], 'yright notice.' ) ) {
 						$metadata[ $key ] = 'Cop' . $metadata[ $key ];

tests/phpunit/tests/media/wpAddId3TagData.php

@@ -0,0 +1,57 @@
+<?php
+/**
+ * Tests for the `wp_add_id3_tag_data()` function.
+ *
+ * @group media
+ * @covers ::wp_add_id3_tag_data
+ */
+class Tests_Media_WpAddId3TagData extends WP_UnitTestCase {
+
+	/**
+	 * Performs cleanup after each test.
+	 */
+	public function tear_down() {
+		$this->remove_added_uploads();
+		parent::tear_down();
+	}
+
+	/**
+	 * Test that wp_add_id3_tag_data handles non-string data without fatal error.
+	 *
+	 * @ticket 63529
+	 */
+	public function test_wp_add_id3_tag_data_handles_non_string_data() {
+		$metadata = array();
+
+		// Simulate ID3 data with array values that cause wp_kses_post to fail
+		$data = array(
+			'id3v2' => array(
+				'comments' => array(
+					'artist'          => 'The Northern Lights Ensemble',
+					'album'           => 'Horizons and Beyond',
+					'title'           => 'Aurora Rising',
+					'involved_people' => array(
+						array(
+							'role' => 'Mastered by Lead Audio Engineer',
+							'name' => 'Emma Clarke',
+						),
+						array(
+							'role' => 'Mixed by Senior Sound Designer',
+							'name' => 'Daniel Perez',
+						),
+					),
+				),
+			),
+		);
+
+		// This should not cause a fatal error when wp_kses_post receives array values
+		wp_add_id3_tag_data( $metadata, $data );
+
+		// Verify the function handled the array data gracefully
+		$this->assertIsArray( $metadata );
+		$this->assertArrayHasKey( 'artist', $metadata );
+		$this->assertArrayHasKey( 'album', $metadata );
+		$this->assertArrayHasKey( 'title', $metadata );
+		$this->assertArrayHasKey( 'involved_people', $metadata );
+	}
+}