Skip to content

Commit d664c3c

Browse files
Coding Standards: Correct $post parameter default values in link-template.php.
This commit corrects the default post ID parameter values used in several functions to bring them in line with their `int` doctypes (and the doctypes of their internal function calls). More specifically, * `get_page_link()`: `$post = false` changed to `$post = 0` * `_get_page_link()`: `$post = false` changed to `$post = 0` * `post_comments_feed_link()`: `$post_id = ''` changed to `$post_id = 0` Follow-up to [1752], [4475], [6365], [9136], [9274], [21735], [24490], [32606], [37252]. Props justlevine. See #63268. git-svn-id: https://develop.svn.wordpress.org/trunk@60152 602fd350-edb4-49c9-b593-d223f7449a82
1 parent 4ce25a5 commit d664c3c

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/wp-includes/link-template.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -388,7 +388,7 @@ function get_post_permalink( $post = 0, $leavename = false, $sample = false ) {
388388
* Default false.
389389
* @return string The page permalink.
390390
*/
391-
function get_page_link( $post = false, $leavename = false, $sample = false ) {
391+
function get_page_link( $post = 0, $leavename = false, $sample = false ) {
392392
$post = get_post( $post );
393393

394394
if ( 'page' === get_option( 'show_on_front' ) && (int) get_option( 'page_on_front' ) === $post->ID ) {
@@ -425,7 +425,7 @@ function get_page_link( $post = false, $leavename = false, $sample = false ) {
425425
* Default false.
426426
* @return string The page permalink.
427427
*/
428-
function _get_page_link( $post = false, $leavename = false, $sample = false ) {
428+
function _get_page_link( $post = 0, $leavename = false, $sample = false ) {
429429
global $wp_rewrite;
430430

431431
$post = get_post( $post );
@@ -834,7 +834,7 @@ function get_post_comments_feed_link( $post_id = 0, $feed = '' ) {
834834
* @param string $feed Optional. Feed type. Possible values include 'rss2', 'atom'.
835835
* Default is the value of get_default_feed().
836836
*/
837-
function post_comments_feed_link( $link_text = '', $post_id = '', $feed = '' ) {
837+
function post_comments_feed_link( $link_text = '', $post_id = 0, $feed = '' ) {
838838
$url = get_post_comments_feed_link( $post_id, $feed );
839839
if ( empty( $link_text ) ) {
840840
$link_text = __( 'Comments Feed' );

0 commit comments

Comments
 (0)