fix: handle fileperms() errors in getchmod()

Fixes the documented FIXME by returning false when fileperms() fails.

Author: vietcgi

src/wp-admin/includes/class-wp-filesystem-direct.php

@@ -249,15 +249,19 @@ public function owner( $file ) {
 	/**
 	 * Gets the permissions of the specified file or filepath in their octal format.
 	 *
-	 * FIXME does not handle errors in fileperms()
-	 *
 	 * @since 2.5.0
 	 *
 	 * @param string $file Path to the file.
-	 * @return string Mode of the file (the last 3 digits).
+	 * @return string|false Mode of the file (the last 3 digits), false on failure.
 	 */
 	public function getchmod( $file ) {
-		return substr( decoct( @fileperms( $file ) ), -3 );
+		$perms = @fileperms( $file );
+
+		if ( false === $perms ) {
+			return false;
+		}
+
+		return substr( decoct( $perms ), -3 );
 	}
 
 	/**

tests/phpunit/tests/filesystem/wpFilesystemDirect/getchmod.php

@@ -33,16 +33,16 @@ public function test_should_get_chmod_for_a_path_that_exists( $path ) {
 
 	/**
 	 * Tests that `WP_Filesystem_Direct::getchmod()` returns
-	 * the permissions for a path that does not exist.
+	 * false for a path that does not exist.
 	 *
 	 * @dataProvider data_paths_that_do_not_exist
 	 *
 	 * @ticket 57774
 	 *
 	 * @param string $path The path.
 	 */
-	public function test_should_get_chmod_for_a_path_that_does_not_exist( $path ) {
+	public function test_should_return_false_for_a_path_that_does_not_exist( $path ) {
 		$actual = self::$filesystem->getchmod( self::$file_structure['test_dir']['path'] . $path );
-		$this->assertNotSame( '', $actual );
+		$this->assertFalse( $actual );
 	}
 }