Apply suggestion from @TimothyBJacobs

ramonjd · TimothyBJacobs · ramonjd · commit dfcab8442968 · 2025-10-07T16:37:48.000+11:00
combine isset

Co-authored-by: Timothy Jacobs &lt;timothy@ironbounddesigns.com&gt;
diff --git a/src/wp-includes/rest-api/endpoints/class-wp-rest-attachments-controller.php b/src/wp-includes/rest-api/endpoints/class-wp-rest-attachments-controller.php
@@ -102,7 +102,7 @@ protected function prepare_items_query( $prepared_args = array(), $request = nul
 		}
 
 		// Map to proper WP_Query orderby param - this needs to happen AFTER parent class
-		if ( isset( $query_args['orderby'] ) && isset( $request['orderby'] ) ) {
+		if ( isset( $query_args['orderby'], $request['orderby'] ) ) {
 			$orderby_mappings = array(
 				'mime_type' => 'post_mime_type',
 			);

Original file line number	Diff line number	Diff line change
`@@ -102,7 +102,7 @@ protected function prepare_items_query( $prepared_args = array(), $request = nul`
`102`	`102`	`}`
`103`	`103`
`104`	`104`	`// Map to proper WP_Query orderby param - this needs to happen AFTER parent class`
`105`		`- if ( isset( $query_args['orderby'] ) && isset( $request['orderby'] ) ) {`
	`105`	`+ if ( isset( $query_args['orderby'], $request['orderby'] ) ) {`
`106`	`106`	`$orderby_mappings = array(`
`107`	`107`	`'mime_type' => 'post_mime_type',`
`108`	`108`	`);`