Skip to content

Commit e63f7d9

Browse files
committed
Twenty Nineteen: Make mobile nav menu scrollable.
This changeset fixes an issue where Twenty Nineteen's primary nav menu panel wasn’t scrollable when the primary menu contains a lot of items, preventing to scroll down to see all menu items. Props kjellr, karmatosed, lakshyajeet, coralietixeront, Spaceshipone, maxpertici, beryldlg. Fixes #45902. git-svn-id: https://develop.svn.wordpress.org/trunk@60302 602fd350-edb4-49c9-b593-d223f7449a82
1 parent eeb8fbf commit e63f7d9

File tree

3 files changed

+15
-3
lines changed

3 files changed

+15
-3
lines changed

src/wp-content/themes/twentynineteen/sass/navigation/_menu-main-navigation.scss

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -433,9 +433,13 @@
433433
white-space: inherit;
434434
}
435435

436+
&:not(:has(.sub-menu.expanded-true)) {
437+
overflow-y: scroll;
438+
}
439+
436440
&.expanded-true {
437441

438-
display: table;
442+
display: block;
439443
margin-top: 0;
440444
opacity: 1;
441445
padding-left: 0;

src/wp-content/themes/twentynineteen/style-rtl.css

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3271,8 +3271,12 @@ body.page .main-navigation {
32713271
white-space: inherit;
32723272
}
32733273

3274+
.main-navigation .main-menu .menu-item-has-children.off-canvas .sub-menu:not(:has(.sub-menu.expanded-true)) {
3275+
overflow-y: scroll;
3276+
}
3277+
32743278
.main-navigation .main-menu .menu-item-has-children.off-canvas .sub-menu.expanded-true {
3275-
display: table;
3279+
display: block;
32763280
margin-top: 0;
32773281
opacity: 1;
32783282
padding-right: 0;

src/wp-content/themes/twentynineteen/style.css

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3271,8 +3271,12 @@ body.page .main-navigation {
32713271
white-space: inherit;
32723272
}
32733273

3274+
.main-navigation .main-menu .menu-item-has-children.off-canvas .sub-menu:not(:has(.sub-menu.expanded-true)) {
3275+
overflow-y: scroll;
3276+
}
3277+
32743278
.main-navigation .main-menu .menu-item-has-children.off-canvas .sub-menu.expanded-true {
3275-
display: table;
3279+
display: block;
32763280
margin-top: 0;
32773281
opacity: 1;
32783282
padding-left: 0;

0 commit comments

Comments
 (0)