Apply suggestions from code review

Co-authored-by: Timothy Jacobs <[email protected]>

Author: gziolo

src/wp-includes/rest-api/endpoints/class-wp-rest-abilities-list-controller.php

@@ -57,7 +57,7 @@ public function register_routes(): void {
 				array(
 					'methods'             => WP_REST_Server::READABLE,
 					'callback'            => array( $this, 'get_items' ),
-					'permission_callback' => array( $this, 'get_permissions_check' ),
+					'permission_callback' => array( $this, 'get_items_permissions_check' ),
 					'args'                => $this->get_collection_params(),
 				),
 				'schema' => array( $this, 'get_public_item_schema' ),
@@ -78,7 +78,7 @@ public function register_routes(): void {
 				array(
 					'methods'             => WP_REST_Server::READABLE,
 					'callback'            => array( $this, 'get_item' ),
-					'permission_callback' => array( $this, 'get_permissions_check' ),
+					'permission_callback' => array( $this, 'get_item_permissions_check' ),
 				),
 				'schema' => array( $this, 'get_public_item_schema' ),
 			)
@@ -102,7 +102,7 @@ static function ( $ability ) {
 		);
 
 		// Filter by ability category if specified.
-		$category = $request->get_param( 'category' );
+		$category = $request['category'];
 		if ( ! empty( $category ) ) {
 			$abilities = array_filter(
 				$abilities,
@@ -114,10 +114,8 @@ static function ( $ability ) use ( $category ) {
 			$abilities = array_values( $abilities );
 		}
 
-		// Handle pagination with explicit defaults.
-		$params   = $request->get_params();
-		$page     = $params['page'] ?? 1;
-		$per_page = $params['per_page'] ?? self::DEFAULT_PER_PAGE;
+		$page     = $request['page'];
+		$per_page = $request['per_page'];
 		$offset   = ( $page - 1 ) * $per_page;
 
 		$total_abilities = count( $abilities );
@@ -167,7 +165,7 @@ static function ( $ability ) use ( $category ) {
 	 * @return WP_REST_Response|WP_Error Response object on success, or WP_Error object on failure.
 	 */
 	public function get_item( $request ) {
-		$ability = wp_get_ability( $request->get_param( 'name' ) );
+		$ability = wp_get_ability( $request['name'] );
 		if ( ! $ability || ! $ability->get_meta_item( 'show_in_rest' ) ) {
 			return new WP_Error(
 				'rest_ability_not_found',
@@ -185,7 +183,7 @@ public function get_item( $request ) {
 	 *
 	 * @since 6.9.0
 	 *
-	 * @param WP_REST_Request<array<string, mixed>> $request Full details about the request.
+	 * @param WP_REST_Request $request Full details about the request.
 	 * @return bool True if the request has read access.
 	 */
 	public function get_permissions_check( $request ) {
@@ -212,7 +210,7 @@ public function prepare_item_for_response( $ability, $request ) {
 			'meta'          => $ability->get_meta(),
 		);
 
-		$context = $request->get_param( 'context' ) ?? 'view';
+		$context = $request['context'];
 		$data    = $this->add_additional_fields_to_object( $data, $request );
 		$data    = $this->filter_response_by_context( $data, $context );
 
@@ -295,7 +293,6 @@ public function get_item_schema(): array {
 					'readonly'    => true,
 				),
 			),
-			'required'   => array( 'name', 'label', 'meta', 'description', 'category', 'input_schema', 'output_schema' ),
 		);
 
 		return $this->add_additional_fields_schema( $schema );

src/wp-includes/rest-api/endpoints/class-wp-rest-abilities-run-controller.php

@@ -80,7 +80,7 @@ public function register_routes(): void {
 	 * @return WP_REST_Response|WP_Error Response object on success, or WP_Error object on failure.
 	 */
 	public function execute_ability( $request ) {
-		$ability = wp_get_ability( $request->get_param( 'name' ) );
+		$ability = wp_get_ability( $request['name'] );
 		if ( ! $ability ) {
 			return new WP_Error(
 				'rest_ability_not_found',
@@ -144,7 +144,7 @@ public function validate_request_method( string $request_method, array $annotati
 	 * @return true|WP_Error True if the request has execution permission, WP_Error object otherwise.
 	 */
 	public function check_ability_permissions( $request ) {
-		$ability = wp_get_ability( $request->get_param( 'name' ) );
+		$ability = wp_get_ability( $request['name'] );
 		if ( ! $ability || ! $ability->get_meta_item( 'show_in_rest' ) ) {
 			return new WP_Error(
 				'rest_ability_not_found',