Skip to content

Commit ea08277

Browse files
Code Modernization: Rename parameters that use reserved keywords in phpunit/tests/pluggable/signatures.php.
While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names. This commit renames the `$function` parameter to `$function_name` in `Tests_Pluggable_Signatures::test_pluggable_function_signatures_match()`. Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232], [53236], [53239], [53240], [53242], [53243], [53245], [53246], [53257], [53269], [53270], [53271], [53272], [53273], [53274], [53275], [53276], [53277], [53281], [53283], [53284], [53285], [53287], [53364], [53365], [54927], [54929], [54930], [54931], [54932], [54933], [54938], [54943], [54944], [54945], [54946], [54947], [54948], [54950], [54951], [54952], [54956], [54959], [54960], [54961], [54962], [54964], [54965], [54969], [54970], [54971], [54972], [54996], [55000], [55011], [55013], [55014], [55015], [55016], [55017], [55020], [55021], [55023], [55027], [55028], [55034], [55036], [55037], [55038], [55039], [55049], [55050], [55060], [55062], [55064], [55065], [55076], [55077], [55078], [55081], [55090], [55100], [55104]. Props jrf, aristath, poena, justinahinon, SergeyBiryukov. See #56788. git-svn-id: https://develop.svn.wordpress.org/trunk@55112 602fd350-edb4-49c9-b593-d223f7449a82
1 parent 9822010 commit ea08277

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

tests/phpunit/tests/pluggable/signatures.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,21 +15,21 @@ class Tests_Pluggable_Signatures extends WP_UnitTestCase {
1515
*
1616
* @dataProvider get_defined_pluggable_functions
1717
*/
18-
public function test_pluggable_function_signatures_match( $function ) {
18+
public function test_pluggable_function_signatures_match( $function_name ) {
1919

2020
$signatures = $this->get_pluggable_function_signatures();
2121

22-
$this->assertTrue( function_exists( $function ) );
23-
$this->assertArrayHasKey( $function, $signatures );
22+
$this->assertTrue( function_exists( $function_name ) );
23+
$this->assertArrayHasKey( $function_name, $signatures );
2424

25-
$function_ref = new ReflectionFunction( $function );
25+
$function_ref = new ReflectionFunction( $function_name );
2626
$param_refs = $function_ref->getParameters();
2727

28-
$this->assertSame( count( $signatures[ $function ] ), count( $param_refs ) );
28+
$this->assertSame( count( $signatures[ $function_name ] ), count( $param_refs ) );
2929

3030
$i = 0;
3131

32-
foreach ( $signatures[ $function ] as $name => $value ) {
32+
foreach ( $signatures[ $function_name ] as $name => $value ) {
3333

3434
$param_ref = $param_refs[ $i ];
3535
$msg = 'Parameter: ' . $param_ref->getName();

0 commit comments

Comments
 (0)