Code Modernization: Fix instances of using null as an array offset.

Addresses a new [https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_using_values_null_as_an_array_offset_and_when_calling_array_key_exists deprecation in PHP 8.5].

Props swissspidy.
Fixes #63957.

git-svn-id: https://develop.svn.wordpress.org/trunk@60809 602fd350-edb4-49c9-b593-d223f7449a82

Author: swissspidy

src/wp-includes/block-bindings.php

@@ -148,8 +148,9 @@ function get_block_bindings_supported_attributes( $block_type ) {
 	);
 
 	$supported_block_attributes =
-		$block_bindings_supported_attributes[ $block_type ] ??
-		array();
+		isset( $block_type, $block_bindings_supported_attributes[ $block_type ] ) ?
+			$block_bindings_supported_attributes[ $block_type ] :
+			array();
 
 	/**
 	 * Filters the supported block attributes for block bindings.

src/wp-includes/blocks.php

@@ -938,7 +938,7 @@ function get_hooked_blocks() {
  */
 function insert_hooked_blocks( &$parsed_anchor_block, $relative_position, $hooked_blocks, $context ) {
 	$anchor_block_type  = $parsed_anchor_block['blockName'];
-	$hooked_block_types = isset( $hooked_blocks[ $anchor_block_type ][ $relative_position ] )
+	$hooked_block_types = isset( $anchor_block_type, $hooked_blocks[ $anchor_block_type ][ $relative_position ] )
 		? $hooked_blocks[ $anchor_block_type ][ $relative_position ]
 		: array();
 
@@ -1029,7 +1029,7 @@ function insert_hooked_blocks( &$parsed_anchor_block, $relative_position, $hooke
  */
 function set_ignored_hooked_blocks_metadata( &$parsed_anchor_block, $relative_position, $hooked_blocks, $context ) {
 	$anchor_block_type  = $parsed_anchor_block['blockName'];
-	$hooked_block_types = isset( $hooked_blocks[ $anchor_block_type ][ $relative_position ] )
+	$hooked_block_types = isset( $anchor_block_type, $hooked_blocks[ $anchor_block_type ][ $relative_position ] )
 		? $hooked_blocks[ $anchor_block_type ][ $relative_position ]
 		: array();
 

src/wp-includes/class-wp-block-type-registry.php

@@ -134,7 +134,7 @@ public function unregister( $name ) {
 	 *
 	 * @since 5.0.0
 	 *
-	 * @param string $name Block type name including namespace.
+	 * @param string|null $name Block type name including namespace.
 	 * @return WP_Block_Type|null The registered block type, or null if it is not registered.
 	 */
 	public function get_registered( $name ) {
@@ -161,11 +161,11 @@ public function get_all_registered() {
 	 *
 	 * @since 5.0.0
 	 *
-	 * @param string $name Block type name including namespace.
+	 * @param string|null $name Block type name including namespace.
 	 * @return bool True if the block type is registered, false otherwise.
 	 */
 	public function is_registered( $name ) {
-		return isset( $this->registered_block_types[ $name ] );
+		return isset( $name, $this->registered_block_types[ $name ] );
 	}
 
 	public function __wakeup() {

src/wp-includes/class-wp-hook.php

@@ -80,6 +80,10 @@ final class WP_Hook implements Iterator, ArrayAccess {
 	 * @param int      $accepted_args The number of arguments the function accepts.
 	 */
 	public function add_filter( $hook_name, $callback, $priority, $accepted_args ) {
+		if ( null === $priority ) {
+			$priority = 0;
+		}
+
 		$idx = _wp_filter_build_unique_id( $hook_name, $callback, $priority );
 
 		$priority_existed = isset( $this->callbacks[ $priority ] );
@@ -187,9 +191,13 @@ private function resort_active_iterations( $new_priority = false, $priority_exis
 	 * @return bool Whether the callback existed before it was removed.
 	 */
 	public function remove_filter( $hook_name, $callback, $priority ) {
+		if ( null === $priority ) {
+			$priority = 0;
+		}
+
 		$function_key = _wp_filter_build_unique_id( $hook_name, $callback, $priority );
 
-		$exists = isset( $this->callbacks[ $priority ][ $function_key ] );
+		$exists = isset( $function_key, $this->callbacks[ $priority ][ $function_key ] );
 
 		if ( $exists ) {
 			unset( $this->callbacks[ $priority ][ $function_key ] );

src/wp-includes/class-wp-theme-json.php

@@ -2889,7 +2889,7 @@ static function ( $split_selector ) use ( $clean_style_variation_selector ) {
 
 		$element_pseudo_allowed = array();
 
-		if ( isset( static::VALID_ELEMENT_PSEUDO_SELECTORS[ $current_element ] ) ) {
+		if ( isset( $current_element, static::VALID_ELEMENT_PSEUDO_SELECTORS[ $current_element ] ) ) {
 			$element_pseudo_allowed = static::VALID_ELEMENT_PSEUDO_SELECTORS[ $current_element ];
 		}
 

src/wp-includes/functions.php

@@ -5101,7 +5101,7 @@ function _wp_array_get( $input_array, $path, $default_value = null ) {
 			 * We check with `isset()` first, as it is a lot faster
 			 * than `array_key_exists()`.
 			 */
-			if ( isset( $input_array[ $path_element ] ) ) {
+			if ( isset( $path_element, $input_array[ $path_element ] ) ) {
 				$input_array = $input_array[ $path_element ];
 				continue;
 			}
@@ -5110,7 +5110,7 @@ function _wp_array_get( $input_array, $path, $default_value = null ) {
 			 * If `isset()` returns false, we check with `array_key_exists()`,
 			 * which also checks for `null` values.
 			 */
-			if ( array_key_exists( $path_element, $input_array ) ) {
+			if ( isset( $path_element ) && array_key_exists( $path_element, $input_array ) ) {
 				$input_array = $input_array[ $path_element ];
 				continue;
 			}

tests/phpunit/data/html-api/token-counting-html-processor.php

@@ -23,6 +23,10 @@ public function next_token(): bool {
 			$token_name = $this->get_token_name();
 		}
 
+		if ( null === $token_name ) {
+			$token_name = '';
+		}
+
 		if ( ! isset( $this->token_seen_count[ $token_name ] ) ) {
 			$this->token_seen_count[ $token_name ] = 1;
 		} else {

tests/phpunit/tests/functions/wpArrayGet.php

@@ -238,19 +238,6 @@ public function test_wp_array_get_null() {
 			),
 			true
 		);
-
-		$this->assertSame(
-			_wp_array_get(
-				array(
-					'key' => array(
-						null => 4,
-					),
-				),
-				array( 'key', null ),
-				true
-			),
-			4
-		);
 	}
 
 	/**

tests/phpunit/tests/post/isPostStatusViewable.php

@@ -140,7 +140,6 @@ public function data_built_unregistered_in_status_types() {
 			array( false, false ),
 			array( true, false ),
 			array( 20, false ),
-			array( null, false ),
 			array( '', false ),
 		);
 	}