Skip to content

Commit f3dc060

Browse files
Code Modernization: Rename parameters that use reserved keywords in phpunit/tests/customize/nav-menus.php.
While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names. This commit renames the `$type` and `$object` parameters to `$object_type` and `$object_name` in `Test_WP_Customize_Nav_Menus::filter_items()`. Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232], [53236], [53239], [53240], [53242], [53243], [53245], [53246], [53257], [53269], [53270], [53271], [53272], [53273], [53274], [53275], [53276], [53277], [53281], [53283], [53284], [53285], [53287], [53364], [53365], [54927], [54929], [54930], [54931], [54932], [54933], [54938], [54943], [54944], [54945], [54946], [54947], [54948], [54950], [54951], [54952], [54956], [54959], [54960], [54961], [54962], [54964], [54965], [54969], [54970], [54971], [54972], [54996], [55000], [55011], [55013], [55014], [55015], [55016], [55017], [55020], [55021], [55023], [55027], [55028], [55034], [55036], [55037], [55038], [55039]. Props jrf, aristath, poena, justinahinon, SergeyBiryukov. See #56788. git-svn-id: https://develop.svn.wordpress.org/trunk@55049 602fd350-edb4-49c9-b593-d223f7449a82
1 parent 80bb61d commit f3dc060

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

tests/phpunit/tests/customize/nav-menus.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -57,18 +57,18 @@ public function filter_item_types( $items ) {
5757
/**
5858
* Filter to add custom menu items.
5959
*
60-
* @param array $items The menu items.
61-
* @param string $type The object type (e.g. taxonomy).
62-
* @param string $object The object name (e.g. category).
60+
* @param array $items The menu items.
61+
* @param string $object_type The object type (e.g. taxonomy).
62+
* @param string $object_name The object name (e.g. category).
6363
* @return array Menu items.
6464
*/
65-
public function filter_items( $items, $type, $object ) {
65+
public function filter_items( $items, $object_type, $object_name ) {
6666
$items[] = array(
6767
'id' => 'custom-1',
6868
'title' => 'Cool beans',
69-
'type' => $type,
69+
'type' => $object_type,
7070
'type_label' => 'Custom Label',
71-
'object' => $object,
71+
'object' => $object_name,
7272
'url' => home_url( '/cool-beans/' ),
7373
'classes' => 'custom-menu-item cool-beans',
7474
);

0 commit comments

Comments
 (0)