Skip to content

fix: send 500 response code on critical errors #10579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shivamdev-lgtm wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

fix: send 500 response code on critical errors #10579

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3280d5b
fix: send 500 response code on critical errors
shivamdev-lgtm Dec 2, 2025
a246dd0
fix: pr reviews
shivamdev-lgtm Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/wp-includes/functions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3886,6 +3886,20 @@ function _default_wp_die_handler( $message, $title = '', $args = array() ) {
$message .= "\n<p><a href='javascript:history.back()'>$back_text</a></p>";
}

// Ensure HTTP 500 status code for critical errors, even if headers were already sent.
$is_critical_error = false;
if ( function_exists( 'is_wp_error' ) && is_wp_error( $message ) ) {
Copy link

@mindctrl mindctrl Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this function_exists check necessary? It's defined in load.php, which is loaded before this file.

References:

wordpress-develop/src/wp-settings.php

Line 37 in 2929fe2

require ABSPATH . WPINC . '/load.php';

wordpress-develop/src/wp-settings.php

Line 117 in 2929fe2

require ABSPATH . WPINC . '/functions.php';

$error_code = $message->get_error_code();
$is_critical_error = ( 'internal_server_error' === $error_code );
} elseif ( 'internal_server_error' === $parsed_args['code'] || 500 === $parsed_args['response'] ) {
$is_critical_error = true;
}

if ( $is_critical_error ) {
$parsed_args['response'] = 500;
http_response_code( 500 );
}

if ( ! did_action( 'admin_head' ) ) :
if ( ! headers_sent() ) {
header( "Content-Type: text/html; charset={$parsed_args['charset']}" );
Expand Down
Loading