Fix ESLint 9 linting in VSCode (#2417)

brandonpayton · adamziel · web-flow · commit 0e5aac639207 · 2025-07-25T14:18:03.000+02:00
## Motivation for the change, related issues Upgrading to ESLint 9 broke real-time linter feedback in VSCode because ESLint 9 defaults to a new "flat config" format which we are not using. Fixes #2416 ## Implementation details This PR restores real-time ESLint feedback by adjusting VSCode workspace settings to use the legacy config format. This PR also adds an explicit "useFlagConfig: false" setting to Nx lint targets. Hopefully, this will prevent NX-based linting breakage when we upgrade to new major Nx version. ## Testing Instructions (or ideally a Blueprint) - CI - Open a `.ts` file in VSCode, add a `console.log()` statement, and observe the the console statement is included in the Problems tab. Co-authored-by: Adam Zieliński <adam@adamziel.com>
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -3,6 +3,7 @@
 	"eslint.validate": [
 		"json"
 	],
+	"eslint.useFlatConfig": false,
 	"files.associations": {
 		"*.embeddedhtml": "html",
 		"api-extractor-base.json": "jsonc",
diff --git a/packages/docs/site/project.json b/packages/docs/site/project.json
@@ -83,6 +83,7 @@
 			"executor": "@nx/linter:eslint",
 			"outputs": ["{options.outputFile}"],
 			"options": {
+				"useFlatConfig": false,
 				"lintFilePatterns": ["packages/docs/site/**/*.ts"],
 				"maxWarnings": 0
 			}
diff --git a/packages/nx-extensions/project.json b/packages/nx-extensions/project.json
@@ -41,6 +41,7 @@
 			"executor": "@nx/linter:eslint",
 			"outputs": ["{options.outputFile}"],
 			"options": {
+				"useFlatConfig": false,
 				"lintFilePatterns": [
 					"packages/nx-extensions/**/*.ts",
 					"packages/nx-extensions/generators.json",
diff --git a/packages/php-wasm/cli/project.json b/packages/php-wasm/cli/project.json
@@ -99,6 +99,7 @@
 			"executor": "@nx/linter:eslint",
 			"outputs": ["{options.outputFile}"],
 			"options": {
+				"useFlatConfig": false,
 				"lintFilePatterns": ["packages/php-wasm/cli/**/*.ts"],
 				"maxWarnings": 0
 			}
diff --git a/packages/php-wasm/fs-journal/project.json b/packages/php-wasm/fs-journal/project.json
@@ -62,6 +62,7 @@
 			"executor": "@nx/linter:eslint",
 			"outputs": ["{options.outputFile}"],
 			"options": {
+				"useFlatConfig": false,
 				"lintFilePatterns": ["packages/php-wasm/fs-journal/**/*.ts"],
 				"maxWarnings": 0
 			}
diff --git a/packages/php-wasm/logger/project.json b/packages/php-wasm/logger/project.json
@@ -60,6 +60,7 @@
 			"executor": "@nx/linter:eslint",
 			"outputs": ["{options.outputFile}"],
 			"options": {
+				"useFlatConfig": false,
 				"lintFilePatterns": ["packages/php-wasm/logger/**/*.ts"],
 				"maxWarnings": 0
 			}
diff --git a/packages/php-wasm/node-polyfills/project.json b/packages/php-wasm/node-polyfills/project.json
@@ -66,6 +66,7 @@
 			"executor": "@nx/linter:eslint",
 			"outputs": ["{options.outputFile}"],
 			"options": {
+				"useFlatConfig": false,
 				"lintFilePatterns": [
 					"packages/php-wasm/node-polyfills/**/*.ts",
 					"packages/php-wasm/node-polyfills/package.json"
diff --git a/packages/php-wasm/node/project.json b/packages/php-wasm/node/project.json
@@ -314,6 +314,7 @@
 			"executor": "@nx/linter:eslint",
 			"outputs": ["{options.outputFile}"],
 			"options": {
+				"useFlatConfig": false,
 				"lintFilePatterns": ["packages/php-wasm/node/**/*.ts"],
 				"maxWarnings": 0
 			}
diff --git a/packages/php-wasm/progress/project.json b/packages/php-wasm/progress/project.json
@@ -56,6 +56,7 @@
 			"executor": "@nx/linter:eslint",
 			"outputs": ["{options.outputFile}"],
 			"options": {
+				"useFlatConfig": false,
 				"lintFilePatterns": ["packages/php-wasm/progress/**/*.ts"],
 				"maxWarnings": 0
 			}
diff --git a/packages/php-wasm/scopes/project.json b/packages/php-wasm/scopes/project.json
@@ -40,6 +40,7 @@
 			"executor": "@nx/linter:eslint",
 			"outputs": ["{options.outputFile}"],
 			"options": {
+				"useFlatConfig": false,
 				"lintFilePatterns": ["packages/php-wasm/scopes/**/*.ts"],
 				"maxWarnings": 0
 			}
diff --git a/packages/php-wasm/stream-compression/project.json b/packages/php-wasm/stream-compression/project.json
@@ -49,6 +49,7 @@
 			"executor": "@nx/linter:eslint",
 			"outputs": ["{options.outputFile}"],
 			"options": {
+				"useFlatConfig": false,
 				"lintFilePatterns": [
 					"packages/php-wasm/stream-compression/**/*.ts",
 					"packages/php-wasm/stream-compression/package.json"
diff --git a/packages/php-wasm/universal/project.json b/packages/php-wasm/universal/project.json
@@ -60,6 +60,7 @@
 			"executor": "@nx/linter:eslint",
 			"outputs": ["{options.outputFile}"],
 			"options": {
+				"useFlatConfig": false,
 				"lintFilePatterns": ["packages/php-wasm/universal/**/*.ts"],
 				"maxWarnings": 0
 			}
diff --git a/packages/php-wasm/util/project.json b/packages/php-wasm/util/project.json
@@ -48,6 +48,7 @@
 			"executor": "@nx/linter:eslint",
 			"outputs": ["{options.outputFile}"],
 			"options": {
+				"useFlatConfig": false,
 				"lintFilePatterns": ["packages/php-wasm/util/**/*.ts"],
 				"maxWarnings": 0
 			}
diff --git a/packages/php-wasm/web-service-worker/project.json b/packages/php-wasm/web-service-worker/project.json
@@ -41,6 +41,7 @@
 			"executor": "@nx/linter:eslint",
 			"outputs": ["{options.outputFile}"],
 			"options": {
+				"useFlatConfig": false,
 				"lintFilePatterns": [
 					"packages/php-wasm/web-service-worker/**/*.ts"
 				],
diff --git a/packages/php-wasm/web/project.json b/packages/php-wasm/web/project.json
@@ -110,6 +110,7 @@
 			"executor": "@nx/linter:eslint",
 			"outputs": ["{options.outputFile}"],
 			"options": {
+				"useFlatConfig": false,
 				"lintFilePatterns": ["packages/php-wasm/web/**/*.ts"],
 				"maxWarnings": 0
 			}
diff --git a/packages/php-wasm/xdebug-bridge/project.json b/packages/php-wasm/xdebug-bridge/project.json
@@ -53,6 +53,7 @@
 			"executor": "@nx/eslint:lint",
 			"outputs": ["{options.outputFile}"],
 			"options": {
+				"useFlatConfig": false,
 				"lintFilePatterns": ["packages/php-wasm/xdebug-bridge/**/*.ts"]
 			}
 		},
diff --git a/packages/playground/blueprints/project.json b/packages/playground/blueprints/project.json
@@ -93,6 +93,7 @@
 			"executor": "@nx/linter:eslint",
 			"outputs": ["{options.outputFile}"],
 			"options": {
+				"useFlatConfig": false,
 				"lintFilePatterns": ["packages/playground/blueprints/**/*.ts"],
 				"maxWarnings": 0
 			}
diff --git a/packages/playground/cli/project.json b/packages/playground/cli/project.json
@@ -127,6 +127,7 @@
 			"executor": "@nx/linter:eslint",
 			"outputs": ["{options.outputFile}"],
 			"options": {
+				"useFlatConfig": false,
 				"lintFilePatterns": ["packages/playground/cli/**/*.ts"],
 				"maxWarnings": 0
 			}
diff --git a/packages/playground/client/project.json b/packages/playground/client/project.json
@@ -82,6 +82,7 @@
 			"executor": "@nx/linter:eslint",
 			"outputs": ["{options.outputFile}"],
 			"options": {
+				"useFlatConfig": false,
 				"lintFilePatterns": ["packages/playground/client/**/*.ts"],
 				"maxWarnings": 0
 			}
diff --git a/packages/playground/common/project.json b/packages/playground/common/project.json
@@ -70,6 +70,7 @@
 			"executor": "@nx/linter:eslint",
 			"outputs": ["{options.outputFile}"],
 			"options": {
+				"useFlatConfig": false,
 				"lintFilePatterns": ["packages/playground/common/**/*.ts"],
 				"maxWarnings": 0
 			}
diff --git a/packages/playground/components/project.json b/packages/playground/components/project.json
@@ -81,6 +81,7 @@
 			"executor": "@nx/linter:eslint",
 			"outputs": ["{options.outputFile}"],
 			"options": {
+				"useFlatConfig": false,
 				"lintFilePatterns": ["packages/playground/components/**/*.ts"],
 				"maxWarnings": 0
 			}
diff --git a/packages/playground/remote/project.json b/packages/playground/remote/project.json
@@ -78,6 +78,7 @@
 			"executor": "@nx/linter:eslint",
 			"outputs": ["{options.outputFile}"],
 			"options": {
+				"useFlatConfig": false,
 				"lintFilePatterns": ["packages/playground/remote/**/*.ts"],
 				"maxWarnings": 0
 			}
diff --git a/packages/playground/storage/project.json b/packages/playground/storage/project.json
@@ -49,6 +49,7 @@
 			"executor": "@nx/linter:eslint",
 			"outputs": ["{options.outputFile}"],
 			"options": {
+				"useFlatConfig": false,
 				"lintFilePatterns": ["packages/playground/storage/**/*.ts"],
 				"maxWarnings": 0
 			}
diff --git a/packages/playground/sync/project.json b/packages/playground/sync/project.json
@@ -83,6 +83,7 @@
 			"executor": "@nx/linter:eslint",
 			"outputs": ["{options.outputFile}"],
 			"options": {
+				"useFlatConfig": false,
 				"lintFilePatterns": [
 					"packages/playground/sync/**/*.{ts,tsx,js,jsx}"
 				],
diff --git a/packages/playground/website/project.json b/packages/playground/website/project.json
@@ -99,6 +99,7 @@
 			"executor": "@nx/linter:eslint",
 			"outputs": ["{options.outputFile}"],
 			"options": {
+				"useFlatConfig": false,
 				"lintFilePatterns": [
 					"packages/playground/website/**/*.{ts,tsx,js,jsx}"
 				],
diff --git a/packages/playground/wordpress-builds/project.json b/packages/playground/wordpress-builds/project.json
@@ -116,6 +116,7 @@
 			"executor": "@nx/linter:eslint",
 			"outputs": ["{options.outputFile}"],
 			"options": {
+				"useFlatConfig": false,
 				"lintFilePatterns": [
 					"packages/playground/wordpress-builds/**/*.ts",
 					"packages/playground/wordpress-builds/package.json"
diff --git a/packages/playground/wordpress/project.json b/packages/playground/wordpress/project.json
@@ -74,6 +74,7 @@
 			"executor": "@nx/linter:eslint",
 			"outputs": ["{options.outputFile}"],
 			"options": {
+				"useFlatConfig": false,
 				"lintFilePatterns": ["packages/playground/wordpress/**/*.ts"],
 				"maxWarnings": 0
 			}

Original file line number	Diff line number	Diff line change
`@@ -83,6 +83,7 @@`
`83`	`83`	`"executor": "@nx/linter:eslint",`
`84`	`84`	`"outputs": ["{options.outputFile}"],`
`85`	`85`	`"options": {`
	`86`	`+ "useFlatConfig": false,`
`86`	`87`	`"lintFilePatterns": ["packages/docs/site/*/.ts"],`
`87`	`88`	`"maxWarnings": 0`
`88`	`89`	`}`
Original file line number	Diff line number	Diff line change
`@@ -99,6 +99,7 @@`
`99`	`99`	`"executor": "@nx/linter:eslint",`
`100`	`100`	`"outputs": ["{options.outputFile}"],`
`101`	`101`	`"options": {`
	`102`	`+ "useFlatConfig": false,`
`102`	`103`	`"lintFilePatterns": ["packages/php-wasm/cli/*/.ts"],`
`103`	`104`	`"maxWarnings": 0`
`104`	`105`	`}`
Original file line number	Diff line number	Diff line change
`@@ -62,6 +62,7 @@`
`62`	`62`	`"executor": "@nx/linter:eslint",`
`63`	`63`	`"outputs": ["{options.outputFile}"],`
`64`	`64`	`"options": {`
	`65`	`+ "useFlatConfig": false,`
`65`	`66`	`"lintFilePatterns": ["packages/php-wasm/fs-journal/*/.ts"],`
`66`	`67`	`"maxWarnings": 0`
`67`	`68`	`}`
Original file line number	Diff line number	Diff line change
`@@ -60,6 +60,7 @@`
`60`	`60`	`"executor": "@nx/linter:eslint",`
`61`	`61`	`"outputs": ["{options.outputFile}"],`
`62`	`62`	`"options": {`
	`63`	`+ "useFlatConfig": false,`
`63`	`64`	`"lintFilePatterns": ["packages/php-wasm/logger/*/.ts"],`
`64`	`65`	`"maxWarnings": 0`
`65`	`66`	`}`
Original file line number	Diff line number	Diff line change
`@@ -314,6 +314,7 @@`
`314`	`314`	`"executor": "@nx/linter:eslint",`
`315`	`315`	`"outputs": ["{options.outputFile}"],`
`316`	`316`	`"options": {`
	`317`	`+ "useFlatConfig": false,`
`317`	`318`	`"lintFilePatterns": ["packages/php-wasm/node/*/.ts"],`
`318`	`319`	`"maxWarnings": 0`
`319`	`320`	`}`
Original file line number	Diff line number	Diff line change
`@@ -56,6 +56,7 @@`
`56`	`56`	`"executor": "@nx/linter:eslint",`
`57`	`57`	`"outputs": ["{options.outputFile}"],`
`58`	`58`	`"options": {`
	`59`	`+ "useFlatConfig": false,`
`59`	`60`	`"lintFilePatterns": ["packages/php-wasm/progress/*/.ts"],`
`60`	`61`	`"maxWarnings": 0`
`61`	`62`	`}`
Original file line number	Diff line number	Diff line change
`@@ -40,6 +40,7 @@`
`40`	`40`	`"executor": "@nx/linter:eslint",`
`41`	`41`	`"outputs": ["{options.outputFile}"],`
`42`	`42`	`"options": {`
	`43`	`+ "useFlatConfig": false,`
`43`	`44`	`"lintFilePatterns": ["packages/php-wasm/scopes/*/.ts"],`
`44`	`45`	`"maxWarnings": 0`
`45`	`46`	`}`