Skip to content

Commit 9d06b72

Browse files
authored
[XDebug Bridge] List additional ASYNCIFY_ONLY functions to prevent unreachable crashes when using Devtools (#2454)
## Motivation for the change, related issues I listed the two crashes I encountered while using Devtools in the comments. I am currently recompiling `php-wasm-node:asyncify`. ## Implementation details Added the following functions in `ASYNCIFY_ONLY_PREFIXED` : ```diff // NEEDED TO PREVENT THE FIRST CRASH + php_fopen_primary_script + persistent_stream_open_function + php_stream_open_for_zend + zend_error_zstr + zend_register_constant + zif_define // NEEDED TO PREVENT THE SECOND CRASH + zend_undefined_index ``` ## Testing Instructions Based on the instructions from #2442 One test is to step into the running files 68 times until breaking on `define( 'WP_DEBUG', false );`. The next step would crash previously. Not anymore. The second test is to quit the Devtools tab while it is running. It crashed previously. Not anymore.
1 parent 45f9afd commit 9d06b72

File tree

19 files changed

+17
-12
lines changed

19 files changed

+17
-12
lines changed

packages/php-wasm/compile/php/Dockerfile

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.

packages/php-wasm/node/asyncify/php_7_2.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)