Commit ceaa432
authored
Further fixes for selected Node.js versions and related CI errors (#3265)
## Summary
- The project's `engines` field was recently downgraded from Node 22
back to `>=20.18.3` (PR #3260), but CI workflows were left on Node 22
(or 23).
- The `Refresh WordPress Major&Beta` and `Refresh SQLite plugin`
workflows were on Node 23 which is outside
`@jest/diff-sequences@30.0.1`'s supported range, causing `npm ci` to
fail with `EBADENGINE`. See [failing
run](https://github.com/WordPress/wordpress-playground/actions/runs/21956463286).
- Switches all workflows to Node 20 (the `prepare-playground` default)
unless they specifically need a later version:
- **Keep Node 22**: `test-playground-cli`, `test-built-npm-packages`,
`test-running-unbuilt-playground-cli` (need
`--experimental-strip-types`)
- **Keep Node 24**: `test-unit-jspi`, `test-redis-extension`,
`test-memcached-extension` (need JSPI)
- **Downgraded to 20**: `test-unit-asyncify`, `build`,
`test-php-wasm-cli-smoke`, `refresh-wordpress-major-and-beta`,
`refresh-sqlite-integration`, `refresh-wordpress-nightly`,
`publish-npm-packages`
- Aligns `engines` field (`node >=20.10.0`, `npm >=10.2.3`) across all
packages with
[wordpress-develop](https://github.com/WordPress/wordpress-develop/blob/trunk/package.json)
to match WordPress core requirements
- Updates `.nvmrc` from `v20.18.3` to `20` (major version only)
- Adds a CI check (`tools/check-node-engine-alignment.sh`) to the
`lint-and-typecheck` job that fetches WordPress Core's `engines.node`
and `engines.npm` from `wordpress-develop/trunk/package.json` and
verifies all local package.json files declare the same values,
preventing future drift
## Test plan
- [x] CI passes on this PR
- [ ] Verify scheduled workflows (`Refresh WordPress Major&Beta`,
`Refresh SQLite plugin`, `Refresh WordPress Nightly`) pass after merge
Note: This PR was created with the assistance of Claude Code.1 parent 7a24787 commit ceaa432
File tree
42 files changed
+224
-144
lines changed- .github/workflows
- packages
- php-wasm
- cli-util
- compile
- fs-journal
- logger
- node-builds
- 7-4
- 8-0
- 8-1
- 8-2
- 8-3
- 8-4
- 8-5
- node
- progress
- scopes
- universal
- util
- web-builds
- 7-4
- 8-0
- 8-1
- 8-2
- 8-3
- 8-4
- 8-5
- web-service-worker
- web
- xdebug-bridge
- playground
- blueprints
- client
- common
- components
- tools
- wordpress-builds
- wordpress
- tools
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
42 files changed
+224
-144
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
| 28 | + | |
28 | 29 | | |
29 | 30 | | |
30 | 31 | | |
| |||
69 | 70 | | |
70 | 71 | | |
71 | 72 | | |
72 | | - | |
| 73 | + | |
73 | 74 | | |
74 | 75 | | |
75 | 76 | | |
| |||
328 | 329 | | |
329 | 330 | | |
330 | 331 | | |
331 | | - | |
| 332 | + | |
332 | 333 | | |
333 | 334 | | |
334 | 335 | | |
| |||
392 | 393 | | |
393 | 394 | | |
394 | 395 | | |
395 | | - | |
| 396 | + | |
396 | 397 | | |
397 | 398 | | |
398 | 399 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
66 | 66 | | |
67 | 67 | | |
68 | 68 | | |
69 | | - | |
| 69 | + | |
70 | 70 | | |
71 | 71 | | |
72 | 72 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
38 | | - | |
| 38 | + | |
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
43 | | - | |
| 43 | + | |
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | | - | |
| 36 | + | |
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
0 commit comments