You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[PHP-wasm Node] Remove unused node creation code from createNodeFsMountHandler (#2379)
## Motivation for the change, related issues
While testing symlink issues in the Playground CLI, I realized that
`statSync(localPath).isSymbolicLink()` will always be false because
`statSync` follows symlinks. When I fixed that issue, I realized that
symlinks must be mounted as either files or directories, otherwise the
`FS.lookupPath` will always [throw errno 44 for the symlinked
path.](https://github.com/WordPress/wordpress-playground/blob/trunk/packages/php-wasm/node/asyncify/php_8_0.js#L3572)
This PR doesn't change any PHP-wasm behavior; it only removes unused
code.
## Testing Instructions (or ideally a Blueprint)
- CI
0 commit comments