-
Notifications
You must be signed in to change notification settings - Fork 362
Add support for private github repos via git:directory #2856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
akirk
wants to merge
7
commits into
trunk
Choose a base branch
from
git-private-repos
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfa80bf to
4f2f5f3
Compare
adamziel
reviewed
Nov 3, 2025
adamziel
reviewed
Nov 3, 2025
adamziel
reviewed
Nov 3, 2025
…b specific code in the git library
0ce57bd to
06b1ae5
Compare
|
Thanks for the review, @adamziel. I have restructured this according to your feedback! I realize that we're modifying the parameters of the git:directory resource inside the blueprint but it seemed like the best way to trickle down the headers from the website to where we need it at the directory resource. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
Currently, WordPress Playground can only fetch git:directory resources from public Github repositories, private ones are not supported.
Related: #2182.
This PR adds Github OAuth authentication support for private repositories:
Note: Because it uses Github OAuth and thus requires a Github user, this is not intended for demoing plugins that reside in private repos, rather for developers to run code in Playground that resides in their own private repositories.
Implementation details
Authentication Flow
UI
Technical Details
Testing Instructions (or ideally a Blueprint)
Test with a private repository:
Expected: Modal prompts for GitHub auth → redirects to GitHub → returns and loads repo successfully without showing modal again.
Verify: Public repos still work without auth, token persists in dev mode (localStorage), no modal persistence issues.