Skip to content

Commit 2d7f789

Browse files
WorkOfStanWorkOfStan
authored
Revert "fix: don't trigger a GitHub Action by a Tag (#13)"
This reverts commit f1d2706.
1 parent f1d2706 commit 2d7f789

File tree

5 files changed

+16
-42
lines changed

5 files changed

+16
-42
lines changed

‎.github/workflows/phpcs-phpcbf.yml‎

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,6 @@
11
---
22
name: Phpcs-fix
3-
4-
on:
5-
push:
6-
branches-ignore:
7-
# notest branches to ignore testing of partial online commits
8-
- "notest/**"
9-
10-
pull_request:
11-
branches-ignore:
12-
# notest branches to ignore testing of partial online commits
13-
- "notest/**"
3+
on: [pull_request, push]
144

155
permissions:
166
contents: write
@@ -22,8 +12,8 @@ jobs:
2212
timeout-minutes: 10
2313
steps:
2414
- name: Invoke the PHPCS check and PHPCBF fix
25-
# Use the latest minor version within the current major version.
26-
uses: WorkOfStan/phpcs-fix@v1
15+
# Use the latest commit in the main branch.
16+
uses: WorkOfStan/phpcs-fix@main
2717
with:
2818
commit-changes: true
2919
#debug: true

‎.github/workflows/polish-the-code.yml‎

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,7 @@ permissions:
2424
jobs:
2525
commit-check:
2626
runs-on: ubuntu-latest
27-
# use permissions because pull-request comments are used
28-
permissions:
27+
permissions: # use permissions because use of pr-comments
2928
contents: read
3029
pull-requests: write
3130
# Limit the running time
@@ -36,15 +35,18 @@ jobs:
3635
ref: ${{ github.event.pull_request.head.sha }} # checkout PR HEAD commit
3736
fetch-depth: 0 # required for merge-base check
3837
persist-credentials: false
39-
- uses: commit-check/commit-check-action@v2
38+
- uses: commit-check/commit-check-action@v1
4039
env:
4140
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # use GITHUB_TOKEN because use of pr-comments
4241
with:
4342
message: true
4443
# to accept dependabot/github_actions/*
45-
# branch: false # todo might not be necessary as "dependabot[bot]" author is ignored
44+
branch: false
4645
author-name: true
4746
author-email: true
47+
commit-signoff: false
48+
merge-base: false
49+
imperative: false
4850
job-summary: true
4951
pr-comments: ${{ github.event_name == 'pull_request' }}
5052

@@ -57,12 +59,12 @@ jobs:
5759
timeout-minutes: 10
5860
steps:
5961
- name: Invoke the Prettier fix
60-
uses: WorkOfStan/prettier-fix@v1
62+
uses: WorkOfStan/prettier-fix@v1.1.6.1
6163
with:
6264
commit-changes: ${{ github.event_name != 'schedule' }}
6365

6466
super-linter:
65-
needs: [prettier-fix, commit-check]
66-
uses: WorkOfStan/seablast-actions/.github/workflows/[email protected].7
67+
needs: prettier-fix
68+
uses: WorkOfStan/seablast-actions/.github/workflows/[email protected].6
6769
with:
6870
runs-on: "ubuntu-latest"

‎CHANGELOG.md‎

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -19,22 +19,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1919

2020
### `Security` in case of vulnerabilities
2121

22-
## [1.0.4] - 2025-10-23
23-
24-
fix: don't trigger a GitHub Action by a Tag
25-
26-
### Changed
27-
28-
- bump GitHub Action's versions
29-
- make the commit message compliant with Conventional Commits
30-
31-
### Fixed
32-
33-
- Trigger changed to ignore tags. I.e. change of the original trigger `on: [pull_request, push]` which caught also tags. (When running on a tag, actions/checkout runs on refs/tags/vX.Y.Z, so you end up with a detached HEAD, and github.head_ref is empty (it only exists on pull_request).)
34-
3522
## [1.0.3] - 2025-10-04
3623

37-
feat: the default commit message made compliant with Conventional Commits
24+
- feat: the default commit message made compliant with Conventional Commits
3825

3926
### Changed
4027

@@ -73,8 +60,7 @@ fix: Fix pull request issues
7360
- The new boolean input `stop-on-manual-fix` will cause the workflow to stop (fail) if manual fixes are necessary. (Also stops with an error if some manual fixes are required on top of automatic fixes.)
7461
- Cached `vendor/` (for a unique combination of php-version and composer.json) after a successful run in order to speed up further runs.
7562

76-
[Unreleased]: https://github.com/WorkOfStan/phpcs-fix/compare/v1.0.4...HEAD?w=1
77-
[1.0.4]: https://github.com/WorkOfStan/phpcs-fix/compare/v1.0.3...v1.0.4?w=1
63+
[Unreleased]: https://github.com/WorkOfStan/phpcs-fix/compare/v1.0.3...HEAD?w=1
7864
[1.0.3]: https://github.com/WorkOfStan/phpcs-fix/compare/v1.0.2...v1.0.3?w=1
7965
[1.0.2]: https://github.com/WorkOfStan/phpcs-fix/compare/v1.0.1...v1.0.2?w=1
8066
[1.0.1]: https://github.com/WorkOfStan/phpcs-fix/compare/v1.0.0...v1.0.1?w=1

‎README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ permissions:
3838
| Input | Description | Type | Default |
3939
| -------------------- | ---------------------------------------------------------------------------------------------------------------------------- | ------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
4040
| `commit-changes` | If set to `true`, the action will commit changes to the current branch; otherwise a new branch is created for manual review. | Boolean | `false` |
41-
| `commit-message` | Commit message to use if the action commits changes. | String | `"chore(phpcf): apply PHP Code Beautifier fixes automatically"` |
41+
| `commit-message` | Commit message to use if the action commits changes. | String | `"chore(phpcf): PHP Code Beautifier fixes applied automatically"` |
4242
| `debug` | Enable extra debug output (list of branches). | Boolean | `false` |
4343
| `extensions` | Comma-delimited list of file extensions to be sniffed. Note: an empty value will disable checking. | String | `"php"` (defaults to PHP only; other file types must be specified) |
4444
| `ignore` | Ignore files based on a comma-separated list of patterns matching files and/or directories. | String | `vendor/` |

‎action.yml‎

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ inputs:
1919
commit-message:
2020
description: "Commit message for the changes"
2121
type: string
22-
default: "chore(phpcf): apply PHP Code Beautifier fixes automatically"
22+
default: "chore(phpcf): PHP Code Beautifier fixes applied automatically"
2323
debug:
2424
description: "Enable extra debug output"
2525
type: boolean
@@ -63,10 +63,6 @@ outputs:
6363
runs:
6464
using: "composite"
6565
steps:
66-
- name: Display version
67-
run: echo "phpcs-fix::v1.0.4 running"
68-
shell: bash
69-
7066
- name: Checkout code
7167
uses: actions/checkout@v5
7268
with:

0 commit comments

Comments
 (0)