Skip to content

Commit dbda4c8

Browse files
authored
Update action.yml phpcbf non-zero exit - warning to investigate
1 parent 3e298bb commit dbda4c8

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

action.yml

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,9 @@ runs:
111111
vendor/bin/phpcbf --extensions="${{ inputs.extensions }}" . --standard="${{ env.USE_STANDARD }}" --ignore="${{ inputs.ignore }}" || MORE_ISSUES=true
112112
: "${MORE_ISSUES:=false}"
113113
if [ "${MORE_ISSUES}" = "true" ]; then
114-
echo "::warning title=Some phpcs issues remained::Manual fix necessary. Compare to the PHP Code Sniffer section above."
114+
#echo "::warning title=Some phpcs issues remained::Manual fix necessary. Compare to the PHP Code Sniffer section above."
115+
# todo investigate when this happens
116+
echo "::warning title=Non-zero code exit of phpcbf::Manual fix necessary?"
115117
fi
116118
117119
# restore composer.json before staging the changes
@@ -156,8 +158,8 @@ runs:
156158
# Set branch name as output
157159
echo "branch-name=$BRANCH_NAME" >> $GITHUB_OUTPUT
158160
159-
# Stop with an error if some manual fixes are required on top of automatic fixes
160-
if [ "${{ inputs.stop-on-manual-fix }}" = "true" ] && [ "${MORE_ISSUES}" = "true" ]; then
161-
exit 1
162-
fi
161+
## Stop with an error if some manual fixes are required on top of automatic fixes
162+
#if [ "${{ inputs.stop-on-manual-fix }}" = "true" ] && [ "${MORE_ISSUES}" = "true" ]; then
163+
# exit 1
164+
#fi
163165
shell: bash

0 commit comments

Comments
 (0)