Deprecate UiComponent.getPropKey, replace with keyForProp

Author: aaronlademann-wf

lib/src/component_declaration/component_base_2.dart

@@ -253,6 +253,13 @@ abstract class UiComponent2<TProps extends UiProps> extends react.Component2
   @override
   Map<String, react.PropValidator<TProps>> get propTypes => {};
 
+  /// Returns the string key of the [factory] prop accessed in [accessProp], including the namespace if one exists.
+  ///
+  /// __DEPRECATED__: This method had to be deprecated and replaced with [keyForProp] because of the way
+  /// that shadowing works in Dart when a top-level function name matches the name of an instance method.
+  @Deprecated('4.0.0')
+  String getPropKey(void Function(TProps props) accessProp) => keyForProp(accessProp);
+
   /// Returns the string key of the [factory] prop accessed in [accessProp], including the namespace if one exists.
   ///
   /// Intended for use within [propTypes].
@@ -277,7 +284,7 @@ abstract class UiComponent2<TProps extends UiProps> extends react.Component2
   ///   }
   /// }
   /// ```
-  String getPropKey(void Function(TProps props) accessProp) => prop_key_util.getPropKey(accessProp, typedPropsFactory);
+  String keyForProp(void Function(TProps props) accessProp) => prop_key_util.getPropKey(accessProp, typedPropsFactory);
 
   // ***************************************************************************
   //

test/over_react/component_declaration/builder_integration_tests/component2/constant_required_accessor_integration_test.dart

@@ -252,7 +252,7 @@ class _$ComponentTestProps extends UiProps {
 class ComponentTestComponent extends UiComponent2<ComponentTestProps> {
   @override
   get propTypes => {
-      getPropKey((p) => p.requiredAndLengthLimited): (props, info) {
+      this.getPropKey((p) => p.requiredAndLengthLimited): (props, info) {
         final length = props.requiredAndLengthLimited?.length;
         if (length != 2) {
           return PropError.value(length, info.propName, 'must have a length of 2');

test/over_react/component_declaration/builder_integration_tests/component2/required_accessor_integration_test.dart

@@ -256,7 +256,7 @@ class _$ComponentTestProps extends UiProps {
 class ComponentTestComponent extends UiComponent2<ComponentTestProps> {
   @override
   get propTypes => {
-      getPropKey((p) => p.requiredAndLengthLimited): (props, info) {
+      keyForProp((p) => p.requiredAndLengthLimited): (props, info) {
         final length = props.requiredAndLengthLimited?.length;
         if (length != 2) {
           return PropError.value(length, info.propName, 'must have a length of 2');

web/component2/src/demo_components/prop_validation.dart

@@ -33,7 +33,7 @@ class PropTypesTestComponent extends UiComponent2<PropTypesTestProps> {
   // This is closer to what it looks like in JS, but might be confusing syntax.
   @override
   get propTypes => {
-        getPropKey((p) => p.twoObjects): (props, info) {
+        keyForProp((p) => p.twoObjects): (props, info) {
           final length = props.twoObjects?.length;
           if (length != 2) {
             return PropError.value(length, info.propName, 'must have a length of 2');