Skip to content

Commit 5bebc8b

Browse files
Merge pull request #80 from Workiva/greglittlefield-wf-patch-1
UIP-2399 Release over_react 1.11.2
2 parents 40f4735 + 127d97e commit 5bebc8b

File tree

4 files changed

+15
-4
lines changed

4 files changed

+15
-4
lines changed

CHANGELOG.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,13 @@
11
# OverReact Changelog
22

3+
## 1.11.2
4+
5+
> [Complete `1.11.2` Changeset](https://github.com/Workiva/over_react/compare/1.11.1...1.11.2)
6+
7+
__Improvements__
8+
9+
* [e805b79b](https://github.com/Workiva/over_react/commit/e805b79b56f90989194ebf0a7951357e7b40f75c) Null-coalesce `isDisposedOrDisposing` to ease consumer test breakages
10+
311
## 1.11.1
412

513
> [Complete `1.11.1` Changeset](https://github.com/Workiva/over_react/compare/1.11.0...1.11.1)

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242

4343
```yaml
4444
dependencies:
45-
over_react: "^1.11.1"
45+
over_react: "^1.11.2"
4646
```
4747
4848
2. Add the `over_react` [transformer] to your `pubspec.yaml`.

lib/src/component_declaration/flux_component.dart

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -152,12 +152,15 @@ abstract class _FluxComponentMixin<TProps extends FluxUiProps> implements Batche
152152

153153
handlers.forEach((store, handler) {
154154
String message = 'Cannot listen to a disposed/disposing Store.';
155-
assert(!store.isDisposedOrDisposing, '$message This can be caused by BatchedRedraws '
155+
156+
var isDisposedOrDisposing = store.isDisposedOrDisposing ?? false;
157+
158+
assert(!isDisposedOrDisposing, '$message This can be caused by BatchedRedraws '
156159
'mounting the component asynchronously after the store has been disposed. If you are '
157160
'in a test environment, try adding an `await window.animationFrame;` before disposing your '
158161
'store.');
159162

160-
if (store.isDisposedOrDisposing) _logger.warning(message);
163+
if (isDisposedOrDisposing) _logger.warning(message);
161164

162165
StreamSubscription subscription = store.listen(handler);
163166
_subscriptions.add(subscription);

pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: over_react
2-
version: 1.11.1
2+
version: 1.11.2
33
description: A library for building statically-typed React UI components using Dart.
44
homepage: https://github.com/Workiva/over_react/
55
authors:

0 commit comments

Comments
 (0)