Skip to content

Commit ada853b

Browse files
Merge pull request #66 from Workiva/transition_hotfix
UIP-2260 Release over_react 1.9.1 (HOTFIX)
2 parents 7fde32b + 1f41e0b commit ada853b

File tree

3 files changed

+14
-9
lines changed

3 files changed

+14
-9
lines changed

CHANGELOG.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,16 @@
11
# OverReact Changelog
22

33

4+
## 1.9.1
5+
6+
> [Complete `1.9.1` Changeset](https://github.com/Workiva/over_react/compare/1.9.0...1.9.1)
7+
8+
__Bug Fixes__
9+
10+
* [#66]: Fix regression with transitions not completing in consumers of AbstractTransition that don't call `super.componentDidMount`
11+
12+
 
13+
414
## 1.9.0
515

616
> [Complete `1.9.0` Changeset](https://github.com/Workiva/over_react/compare/1.8.0...1.9.0)

lib/src/component/abstract_transition.dart

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -296,16 +296,11 @@ abstract class AbstractTransitionComponent<T extends AbstractTransitionProps, S
296296
}
297297
}
298298

299-
var _isMounted = false;
300-
301-
@override
302-
void componentDidMount() {
303-
_isMounted = true;
304-
}
299+
var _isUnmounted = false;
305300

306301
@override
307302
void componentWillUnmount() {
308-
_isMounted = false;
303+
_isUnmounted = true;
309304
_cancelTransitionEventListener();
310305
}
311306

@@ -359,7 +354,7 @@ abstract class AbstractTransitionComponent<T extends AbstractTransitionProps, S
359354
_cancelTransitionEndTimer();
360355
} else {
361356
onNextTransitionEnd(() {
362-
if (_isMounted && state.transitionPhase == TransitionPhase.HIDING) {
357+
if (!_isUnmounted && state.transitionPhase == TransitionPhase.HIDING) {
363358
setState(newState()
364359
..transitionPhase = TransitionPhase.HIDDEN
365360
);

pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: over_react
2-
version: 1.9.0
2+
version: 1.9.1
33
description: A library for building statically-typed React UI components using Dart.
44
homepage: https://github.com/Workiva/over_react/
55
authors:

0 commit comments

Comments
 (0)