Skip to content

Commit cc4de58

Browse files
authored
Merge pull request #296 from Workiva/release_over_react_2.4.2+dart2
CPLAT-5264 CPLAT-5263 Release over_react 2.4.2+dart2
2 parents fdab082 + b4e62ec commit cc4de58

File tree

5 files changed

+22
-2
lines changed

5 files changed

+22
-2
lines changed

CHANGELOG.md

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,16 @@
11
# OverReact Changelog
22

3+
## 2.4.2
4+
5+
> Complete `2.4.2` Changsets:
6+
>
7+
> - [Dart 2](https://github.com/Workiva/over_react/compare/2.4.1+dart2...2.4.2+dart2)
8+
> - [Dart 1](https://github.com/Workiva/over_react/compare/2.4.1+dart1...2.4.2+dart1)
9+
10+
* [#288] Downgrade parse error to fine so as to not fail build unnecessarily.
11+
* [#292] Update `react` dependency to version `^4.7.0`, and remove references to deprecated `jsify`, `getProperty` and `setProperty` members.
12+
* [#294] Fix issue with `AbstractTransitionComponent` that causes ReactJS `setState` warnings to appear in the browser console.
13+
314
## 2.4.1
415

516
> Complete `2.4.1` Changsets:
@@ -123,6 +134,13 @@ __Breaking Changes__
123134
* `getJsProps()` - use `getProps()` instead
124135
* `$Props` and `$PropKeys` - see the migration guide above
125136
137+
## 1.33.2
138+
139+
* [#292] Update `react` dependency to version `^4.7.0`, and remove references to deprecated `jsify`, `getProperty` and `setProperty` members.
140+
* [#294] Fix issue with `AbstractTransitionComponent` that causes ReactJS `setState` warnings to appear in the browser console.
141+
142+
143+
126144
## 1.33.1
127145
128146
* [#272] Add `min-height: 0` to `ResizeSensor` wrapper nodes to fix issues with it not shrinking in a flexbox layout

lib/src/component/abstract_transition.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -310,6 +310,7 @@ abstract class AbstractTransitionComponent<T extends AbstractTransitionProps,
310310
void componentWillUnmount() {
311311
super.componentWillUnmount();
312312
_isUnmounted = true;
313+
_cancelTransitionEndTimer();
313314
_cancelTransitionEventListener();
314315
}
315316

lib/src/component_declaration/component_type_checking.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ void setComponentTypeMeta(ReactDartComponentFactoryProxy factory, {
5050
bool isWrapper,
5151
ReactDartComponentFactoryProxy parentType
5252
}) {
53+
// ignore: argument_type_not_assignable
5354
setProperty(factory.type, _componentTypeMetaKey, new ComponentTypeMeta(isWrapper, parentType));
5455
}
5556

pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: over_react
2-
version: 2.4.1+dart2
2+
version: 2.4.2+dart2
33
description: A library for building statically-typed React UI components using Dart.
44
homepage: https://github.com/Workiva/over_react/
55
authors:

test/over_react/util/react_wrappers_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -992,7 +992,7 @@ main() {
992992

993993
test('a String', () {
994994
expect(() => getProps('string'), throwsArgumentError);
995-
});
995+
}, testOn: 'js');
996996

997997
test('null', () {
998998
expect(() => getProps(null), throwsArgumentError);

0 commit comments

Comments
 (0)