Merge pull request #273 from Workiva/1.33.1-release-base

CPLAT-4891 CPLAT-4890 Release over_react 1.33.1

Author: rmconsole3-wf

CHANGELOG.md

@@ -1,5 +1,9 @@
 # OverReact Changelog
 
+## 1.33.1
+
+* [#272] Add `min-height: 0` to `ResizeSensor` wrapper nodes to fix issues with it not shrinking in a flexbox layout
+
 ## 1.33.0
 
 > [Complete `1.33.0` Changeset](https://github.com/Workiva/over_react/compare/1.32.0...1.33.0)

lib/src/component/resize_sensor.dart

@@ -463,13 +463,17 @@ const Map<String, dynamic> _wrapperStylesFlexChild = const {
   'flex': '1 1 0%',
   'msFlex': '1 1 0%',
   'display': 'block',
+  // Fix ResizeSensor not shrinking properly: https://www.chromestatus.com/feature/6736527476391936
+  'minHeight': '0',
 };
 
 final Map<String, dynamic> _wrapperStylesFlexContainer = {
   'position': 'relative',
   'flex': '1 1 0%',
   'msFlex': '1 1 0%',
   'display': _displayFlex,
+  // Fix ResizeSensor not shrinking properly: https://www.chromestatus.com/feature/6736527476391936
+  'minHeight': '0',
 };
 
 /// The browser-prefixed value for the CSS `display` property that enables flexbox.

pubspec.yaml

@@ -1,5 +1,5 @@
 name: over_react
-version: 1.33.0
+version: 1.33.1
 description: A library for building statically-typed React UI components using Dart.
 homepage: https://github.com/Workiva/over_react/
 authors:

test/over_react/component/resize_sensor_test.dart

@@ -142,6 +142,7 @@ void main() {
 
         expect(renderedNode.style.position, equals('relative'));
         expect(renderedNode.style.display, equals('block'));
+        expect(renderedNode.style.minHeight, '0px');
 
         var nodeStyleDecl = renderedNode.style;
         if (browser.isInternetExplorer && browser.version.major < 11) {
@@ -157,6 +158,7 @@ void main() {
         var renderedNode = renderAndGetDom((ResizeSensor()..isFlexContainer = true)());
 
         expect(renderedNode.style.position, equals('relative'));
+        expect(renderedNode.style.minHeight, '0px');
 
         var nodeStyleDecl = renderedNode.style;
         if (browser.isInternetExplorer && browser.version.major < 11) {