Skip to content

Commit fc95425

Browse files
Merge pull request #275 from Workiva/release_over_react_2.3.1+dart2
CPLAT-4896, CPLAT-4897 Release over_react 2.3.1+dart2
2 parents 22886f4 + ed610e4 commit fc95425

File tree

4 files changed

+20
-1
lines changed

4 files changed

+20
-1
lines changed

CHANGELOG.md

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,14 @@
11
# OverReact Changelog
22

3+
## 2.3.1
4+
5+
> Complete `2.3.1` Changsets:
6+
>
7+
> - [Dart 2](https://github.com/Workiva/over_react/compare/2.3.0+dart2...2.3.1+dart2)
8+
> - [Dart 1](https://github.com/Workiva/over_react/compare/2.3.0+dart1...2.3.1+dart1)
9+
10+
* [#272] Add `min-height: 0` to `ResizeSensor` wrapper nodes to fix issues with it not shrinking in a flexbox layout
11+
312
## 2.3.0
413

514
> Complete `2.3.0` Changsets:
@@ -93,6 +102,10 @@ __Breaking Changes__
93102
* `getJsProps()` - use `getProps()` instead
94103
* `$Props` and `$PropKeys` - see the migration guide above
95104
105+
## 1.33.1
106+
107+
* [#272] Add `min-height: 0` to `ResizeSensor` wrapper nodes to fix issues with it not shrinking in a flexbox layout
108+
96109
## 1.33.0
97110
98111
> [Complete `1.33.0` Changeset](https://github.com/Workiva/over_react/compare/1.32.0...1.33.0)

lib/src/component/resize_sensor.dart

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -458,13 +458,17 @@ const Map<String, dynamic> _wrapperStylesFlexChild = const {
458458
'flex': '1 1 0%',
459459
'msFlex': '1 1 0%',
460460
'display': 'block',
461+
// Fix ResizeSensor not shrinking properly: https://www.chromestatus.com/feature/6736527476391936
462+
'minHeight': '0',
461463
};
462464

463465
final Map<String, dynamic> _wrapperStylesFlexContainer = {
464466
'position': 'relative',
465467
'flex': '1 1 0%',
466468
'msFlex': '1 1 0%',
467469
'display': _displayFlex,
470+
// Fix ResizeSensor not shrinking properly: https://www.chromestatus.com/feature/6736527476391936
471+
'minHeight': '0',
468472
};
469473

470474
/// The browser-prefixed value for the CSS `display` property that enables flexbox.

pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: over_react
2-
version: 2.3.0+dart2
2+
version: 2.3.1+dart2
33
description: A library for building statically-typed React UI components using Dart.
44
homepage: https://github.com/Workiva/over_react/
55
authors:

test/over_react/component/resize_sensor_test.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,7 @@ void main() {
142142

143143
expect(renderedNode.style.position, equals('relative'));
144144
expect(renderedNode.style.display, equals('block'));
145+
expect(renderedNode.style.minHeight, '0px');
145146

146147
var nodeStyleDecl = renderedNode.style;
147148
if (browser.isInternetExplorer && browser.version.major < 11) {
@@ -157,6 +158,7 @@ void main() {
157158
var renderedNode = renderAndGetDom((ResizeSensor()..isFlexContainer = true)());
158159

159160
expect(renderedNode.style.position, equals('relative'));
161+
expect(renderedNode.style.minHeight, '0px');
160162

161163
var nodeStyleDecl = renderedNode.style;
162164
if (browser.isInternetExplorer && browser.version.major < 11) {

0 commit comments

Comments
 (0)