Skip to content

Commit 341c2b7

Browse files
Merge pull request #26 from Workiva/batch/fedx/unblock_analyzer1
Unblock Analyzer 1
2 parents 6bb2cfb + 6ec7fac commit 341c2b7

File tree

5 files changed

+31
-30
lines changed

5 files changed

+31
-30
lines changed

.github/workflows/dart_ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ jobs:
1515
strategy:
1616
fail-fast: false
1717
matrix:
18-
sdk: [ stable, 2.13.4, dev ]
18+
sdk: [ stable, 2.13.4 ]
1919
steps:
2020
- uses: actions/checkout@v2
2121
- uses: dart-lang/[email protected]
@@ -33,5 +33,5 @@ jobs:
3333
run: dart analyze
3434

3535
- name: Tests
36-
run: dart test
36+
run: dart test --chain-stack-traces
3737
if: ${{ matrix.sdk == '2.13.4' }}

pubspec.yaml

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -11,27 +11,27 @@ environment:
1111
sdk: ">=2.11.0 <3.0.0"
1212

1313
dependencies:
14-
args: '>=1.5.1 <3.0.0'
15-
glob: ^1.1.7
16-
http: ^0.12.0
17-
http_multi_server: ^2.1.0
18-
io: '>=0.3.3 <2.0.0'
19-
logging: '>=0.11.3+2 <2.0.0'
20-
meta: ">=1.1.7 <1.7.0" # pin to avoid issue in 1.7.0
21-
pedantic: ^1.7.0
22-
pub_semver: '>=1.4.2 <3.0.0'
23-
shelf: ^0.7.2
24-
shelf_proxy: ^0.1.0
25-
stack_trace: ^1.9.3
14+
args: ^2.3.1
15+
glob: ^2.0.1
16+
http: ^0.13.3
17+
http_multi_server: ^3.2.1
18+
io: ^1.0.3
19+
logging: ^1.1.0
20+
meta: ^1.8.0
21+
pedantic: ^1.11.1
22+
pub_semver: ^2.1.2
23+
shelf: ^1.2.0
24+
shelf_proxy: ^1.0.0
25+
stack_trace: ^1.10.0
2626

2727
dev_dependencies:
2828
# These two build deps are required by webdev.
29-
build_runner: '>=1.5.1 <3.0.0'
30-
build_web_compilers: '>=2.12.0 <3.0.0'
29+
build_runner: ^2.1.2
30+
build_web_compilers: ^3.0.0
3131

32-
shelf_static: ^0.2.8
33-
sse: ^3.6.1
34-
test: ^1.6.3
32+
shelf_static: ^1.1.0
33+
sse: ^4.1.0
34+
test: ^1.17.12
3535
webdriver: ^3.0.0
3636

3737
executables:

test/proxy_server_test.dart

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ void main() {
6161
);
6262

6363
final response =
64-
await http.get('http://localhost:${proxy.port}/index.dart');
64+
await http.get(Uri.parse('http://localhost:${proxy.port}/index.dart'));
6565
expect(response.statusCode, 200);
6666
expect(response.body, isNotEmpty);
6767
});
@@ -89,8 +89,8 @@ void main() {
8989
rewrite404s: true,
9090
);
9191

92-
final response =
93-
await http.get('http://localhost:${proxy.port}/path/to/nothing');
92+
final response = await http
93+
.get(Uri.parse('http://localhost:${proxy.port}/path/to/nothing'));
9494
expect(response.statusCode, 200);
9595
expect(response.body, startsWith('<!DOCTYPE html>'));
9696
});
@@ -103,8 +103,8 @@ void main() {
103103
rewrite404s: false,
104104
);
105105

106-
final response =
107-
await http.get('http://localhost:${proxy.port}/path/to/nothing');
106+
final response = await http
107+
.get(Uri.parse('http://localhost:${proxy.port}/path/to/nothing'));
108108
expect(response.statusCode, 404);
109109
});
110110
}

test/webdev_proxy_server_test.dart

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ void main() {
6060
);
6161

6262
final response =
63-
await http.get('http://localhost:${proxy.port}/index.dart');
63+
await http.get(Uri.parse('http://localhost:${proxy.port}/index.dart'));
6464
expect(response.statusCode, 200);
6565
expect(response.body, isNotEmpty);
6666
});
@@ -87,8 +87,8 @@ void main() {
8787
rewrite404s: true,
8888
);
8989

90-
final response =
91-
await http.get('http://localhost:${proxy.port}/path/to/nothing');
90+
final response = await http
91+
.get(Uri.parse('http://localhost:${proxy.port}/path/to/nothing'));
9292
expect(response.statusCode, 200);
9393
expect(response.body, startsWith('<!DOCTYPE html>'));
9494
});
@@ -101,8 +101,8 @@ void main() {
101101
rewrite404s: false,
102102
);
103103

104-
final response =
105-
await http.get('http://localhost:${proxy.port}/path/to/nothing');
104+
final response = await http
105+
.get(Uri.parse('http://localhost:${proxy.port}/path/to/nothing'));
106106
expect(response.statusCode, 404);
107107
});
108108
}

test/webdev_server_test.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,8 @@ void main() async {
4242
http.Response response;
4343
while (true) {
4444
try {
45-
response = await http.get('http://localhost:$port/web/index.dart');
45+
response =
46+
await http.get(Uri.parse('http://localhost:$port/web/index.dart'));
4647
} catch (_) {
4748
await Future.delayed(Duration(milliseconds: 250));
4849
continue;

0 commit comments

Comments
 (0)