code review

Author: mikaelcom

src/AbstractAttributeHandler.php

@@ -37,11 +37,6 @@ class AbstractAttributeHandler extends AbstractNodeHandler
 
     const DEFAULT_OCCURRENCE_VALUE = 1;
 
-    public function getNode(): DOMAttr
-    {
-        return parent::getNode();
-    }
-
     public function getAttribute(): DOMAttr
     {
         return $this->getNode();

src/AbstractElementHandler.php

@@ -13,11 +13,6 @@ public function __construct(DOMElement $element, AbstractDomDocumentHandler $dom
         parent::__construct($element, $domDocument, $index);
     }
 
-    public function getNode(): DOMElement
-    {
-        return parent::getNode();
-    }
-
     public function getElement(): DOMElement
     {
         return $this->getNode();

src/AbstractNodeHandler.php

@@ -92,8 +92,12 @@ public function getChildren(): array
         return $this->getHandlers($this->getNode()->childNodes);
     }
 
-    private function getHandlers(Traversable $nodes): array
+    private function getHandlers(?Traversable $nodes): array
     {
+        if (is_null($nodes)) {
+            return [];
+        }
+
         $handlers = array();
         foreach ($nodes as $index => $node) {
             if (!is_int($index)) {

src/DomDocumentHandler.php

@@ -25,7 +25,7 @@ protected function getAttributeHandler(DOMAttr $attribute, AbstractDomDocumentHa
         return new AttributeHandler($attribute, $domDocument, $index);
     }
 
-    public function getRootElement(): ElementHandler
+    public function getRootElement(): ?ElementHandler
     {
         return $this->rootElement;
     }