issue #4 - use official regular expression to validate name

mikaelcom · mikaelcom · commit c4075468fd6b · 2016-02-24T23:20:50.000+01:00
see http://php.net/manual/en/language.variables.basics.php
diff --git a/src/Element/AbstractElement.php b/src/Element/AbstractElement.php
@@ -51,11 +51,11 @@ public function getName()
      */
     public static function nameIsValid($name, $allowBackslash = false)
     {
-        $pattern = '/^[a-zA-Z_][a-zA-Z0-9_]*$/D';
+        $pattern = '/[a-zA-Z_\x7f-\xff][a-zA-Z0-9_\x7f-\xff]*/';
         if ($allowBackslash === true) {
-            $pattern = '/^[a-zA-Z_\\\][a-zA-Z0-9_\\\]*$/D';
+            $pattern = '/[a-zA-Z_\x7f-\xff\\\][a-zA-Z0-9_\x7f-\xff\\\]*/';
         }
-        return preg_match($pattern, $name) === 1;
+        return preg_match($pattern, $name);
     }
     /**
      * @param mixed $string

Original file line number	Diff line number	Diff line change
`@@ -51,11 +51,11 @@ public function getName()`
`51`	`51`	`*/`
`52`	`52`	`public static function nameIsValid($name, $allowBackslash = false)`
`53`	`53`	`{`
`54`		`- $pattern = '/^[a-zA-Z_][a-zA-Z0-9_]*$/D';`
	`54`	`+ $pattern = '/[a-zA-Z_\x7f-\xff][a-zA-Z0-9_\x7f-\xff]*/';`
`55`	`55`	`if ($allowBackslash === true) {`
`56`		`- $pattern = '/^[a-zA-Z_\\\][a-zA-Z0-9_\\\]*$/D';`
	`56`	`+ $pattern = '/[a-zA-Z_\x7f-\xff\\\][a-zA-Z0-9_\x7f-\xff\\\]*/';`
`57`	`57`	`}`
`58`		`- return preg_match($pattern, $name) === 1;`
	`58`	`+ return preg_match($pattern, $name);`
`59`	`59`	`}`
`60`	`60`	`/**`
`61`	`61`	`* @param mixed $string`