Bugfix: simply changing evasys form not correctly working with update

Author: David Ala

classes/option/fields/evasys.php

@@ -553,7 +553,7 @@ public static function changes_collected_action(
         $taskdata = [
             'teacherchanges' => $changes["mod_booking\\option\\fields\\teachers"],
             'namechanges' => $changes["mod_booking\\option\\fields\\text"],
-            'relevantchanges' => isset($changes["bookingextension_evasys\\option\\fields\\evasys"]['changes']) ?? [],
+            'relevantchanges' => $changes["bookingextension_evasys\\option\\fields\\evasys"]['changes'] ?? [],
             'newoption' => $relevantoptiondata,
             'relevantkeyssurvey' => self::$relevantkeyssurvey,
             'relevantkeyscourse' => self::$relevantkeyscourse,

classes/task/evasys_send_to_api.php

@@ -95,6 +95,13 @@ public function execute() {
                     mtrace($this->get_name() . ': Skipping task - no teachers assigned.');
                     return;
                 }
+                // Normalize changed keys so update checks work with array or object payloads.
+                $changedkeys = [];
+                if (is_array($relevantchanges)) {
+                    $changedkeys = array_keys($relevantchanges);
+                } else if (is_object($relevantchanges)) {
+                    $changedkeys = array_keys((array)$relevantchanges);
+                }
                 // If by any chance the option is a selflearningcourse and slips through validation, we skip the task.
                 if (!empty($newoption->selflearningcourse)) {
                     mtrace($this->get_name() . ': Skipping task - option is a self-learning course.');
@@ -144,15 +151,16 @@ public function execute() {
                     }
                     // Checks if the survey and therefore the course needs to be updated.
                     if (!$updatesurvey) {
-                        foreach ($relevantchanges as $key => $value) {
+                        foreach ($changedkeys as $key) {
                             if (in_array($key, $relevantkeyssurvey, true)) {
                                 $updatesurvey = true;
+                                break;
                             }
                         }
                         // Checks for the only key where just the course needs to be updated.
                         if (
                             !$updatesurvey
-                            && isset($courserelevantchanges->$relevankeyscourse)
+                            && !empty(array_intersect($changedkeys, $relevankeyscourse))
                         ) {
                             $updatecourse = true;
                         }