Codechecker Fixes #122

Author: cbadusch

backup/moodle2/backup_mooduell_activity_task.class.php

@@ -31,7 +31,6 @@
  * Provides the steps to perform one complete backup of the Page instance
  */
 class backup_mooduell_activity_task extends backup_activity_task {
-
     /**
      * No specific settings for this activity
      */
@@ -57,11 +56,11 @@ public static function encode_content_links($content) {
         $base = preg_quote($CFG->wwwroot, "/");
 
         // Link to the list of pxages.
-        $search = "/(".$base."\/mod\/mooduell\/index.php\?id\=)([0-9]+)/";
+        $search = "/(" . "$base" . "\/mod\/mooduell\/index.php\?id\=)([0-9]+)/";
         $content = preg_replace($search, '$@MODUELLINDEX*$2@$', $content);
 
         // Link to pxage view by moduleid.
-        $search = "/(".$base."\/mod\/mooduell\/view.php\?id\=)([0-9]+)/";
+        $search = "/(" . "$base" . "\/mod\/mooduell\/view.php\?id\=)([0-9]+)/";
         $content = preg_replace($search, '$@MOODUELLVIEWBYID*$2@$', $content);
 
         return $content;

backup/moodle2/backup_mooduell_stepslib.php

@@ -30,7 +30,6 @@
  * Define the complete mooduell structure for backup, with file and id annotations
  */
 class backup_mooduell_activity_structure_step extends backup_activity_structure_step {
-
     /**
      * define structure.
      * @return backup_nested_element

backup/moodle2/restore_mooduell_activity_task.class.php

@@ -30,7 +30,6 @@
  * mooduell restore task that provides all the settings and steps to perform one complete restore of the activity
  */
 class restore_mooduell_activity_task extends restore_activity_task {
-
     /**
      * Define (add) particular settings this activity can have.
      */
@@ -53,9 +52,11 @@ protected function define_my_steps() {
     public static function define_decode_contents() {
         $contents = [];
 
-        $contents[] = new restore_decode_content('mooduell',
-                ['intro', 'content'],
-                'mooduell');
+        $contents[] = new restore_decode_content(
+            'mooduell',
+            ['intro', 'content'],
+            'mooduell'
+        );
         return $contents;
     }
 
@@ -66,11 +67,13 @@ public static function define_decode_contents() {
     public static function define_decode_rules() {
         $rules = [];
 
-        $rules[] = new restore_decode_rule('MOODUELLVIEWBYID',
-                '/mod/mooduell/view.php?id=$1', 'course_module');
+        $rules[] = new restore_decode_rule(
+            'MOODUELLVIEWBYID',
+            '/mod/mooduell/view.php?id=$1',
+            'course_module'
+        );
 
         return $rules;
-
     }
 
     /**
@@ -80,8 +83,12 @@ public static function define_decode_rules() {
     public static function define_restore_log_rules() {
         $rules = [];
 
-        $rules[] = new restore_log_rule('mooduell',
-                'view', 'view.php?id={course_module}', '{mooduell}');
+        $rules[] = new restore_log_rule(
+            'mooduell',
+            'view',
+            'view.php?id={course_module}',
+            '{mooduell}'
+        );
 
         return $rules;
     }
@@ -97,8 +104,12 @@ public static function define_restore_log_rules() {
     public static function define_restore_log_rules_for_course() {
         $rules = [];
 
-        $rules[] = new restore_log_rule('mooduell',
-                'view all', 'index.php?id={course}', null);
+        $rules[] = new restore_log_rule(
+            'mooduell',
+            'view all',
+            'index.php?id={course}',
+            null
+        );
 
         return $rules;
     }

backup/moodle2/restore_mooduell_stepslib.php

@@ -30,7 +30,6 @@
  * Structure step to restore one mooduell activity
  */
 class restore_mooduell_activity_structure_step extends restore_activity_structure_step {
-
     /**
      * define structure
      * @return mixed
@@ -114,7 +113,6 @@ protected function process_mooduell_games($data) {
         $newgameitemid = $DB->insert_record('mooduell_games', $data);
 
         $this->set_mapping('mooduell_game', $oldid, $newgameitemid);
-
     }
 
     /**

classes/privacy/provider.php

@@ -39,14 +39,9 @@
  * @package mod_mooduell
  */
 class provider implements
-        // This plugin stores personal data.
     \core_privacy\local\metadata\provider,
-
-        // This plugin is a core_user_data_provider.
-    \core_privacy\local\request\plugin\provider,
-
-        // This plugin is capable of determining which users have data within it.
-    \core_privacy\local\request\core_userlist_provider {
+    \core_privacy\local\request\core_userlist_provider,
+    \core_privacy\local\request\plugin\provider {
     /**
      * Return the fields which contain personal data.
      * @param collection $collection a reference to the collection to use to store the metadata.

lib.php

@@ -22,8 +22,6 @@
  * @license     http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 
-defined('MOODLE_INTERNAL') || die();
-
 use core_completion\api;
 use mod_mooduell\mooduell;
 use mod_mooduell\completion\custom_completion;
@@ -341,7 +339,7 @@ function mooduell_pluginfile($course, $cm, $context, $filearea, $args, $forcedow
             // We can now send the file back to the browser - in this case with a cache lifetime of 1 day and no filtering.
             send_stored_file($file, 86400, 0, $forcedownload, $options);
     }
-};
+}
 
 /**
  * Serves files for question text in MooDuell.