Bugfix: Fix Licensekey Error when non Base 64

Author: cbadusch

classes/utils/wb_payment.php

@@ -66,15 +66,17 @@ public static function decryptlicensekey(string $encryptedlicensekey): array {
 
         // Step 2: Decrypt using public key.
         openssl_public_decrypt($encryptedlicensekey, $licensekey, self::MOD_MOODUELL_PUBLIC_KEY);
-
+        if (!$licensekey) {
+            return [];
+        }
         // Step 3: Do another base64 decode and decrypt using wwwroot.
         $c = base64_decode($licensekey);
         $ivlen = openssl_cipher_iv_length($cipher = "AES-128-CBC");
         $iv = substr($c, 0, $ivlen);
 
         // Bugfix when passing wrong license keys that are too short.
         if (strlen($iv) != 16) {
-            return false;
+            return [];
         }
 
         $sha2len = 32;
@@ -102,6 +104,9 @@ public static function pro_version_is_activated() {
             // DEBUG: echo "License key from plugin config: $licensekey_from_settings<br>"; END.
 
             $data = self::decryptlicensekey($licensekeyfromsettings);
+            if ($data == []) {
+                return false;
+            }
             // Return true if the current timestamp has not yet reached the expiration date.
             if (time() < strtotime($data['exptime']) && isset($data['product']) && $data['product'] == 'mooduell') {
                 return true;

settings.php

@@ -47,13 +47,16 @@
     $pluginconfig = get_config('mooduell');
     if (!empty($pluginconfig->licensekey)) {
         $licensekey = $pluginconfig->licensekey;
-
-        $expirationdate = wb_payment::decryptlicensekey($licensekey)['exptime'];
-        if (wb_payment::pro_version_is_activated()) {
-            $licensekeydesc = "<p style='color: green; font-weight: bold'>"
-                . get_string('license_activated', 'mod_mooduell')
-                . $expirationdate
-                . ")</p>";
+        $decryptedlicensekey = wb_payment::decryptlicensekey($licensekey);
+        if (array_key_exists('exptime', $decryptedlicensekey)) {
+            $expirationdate = $decryptedlicensekey['exptime'];
+
+            if (wb_payment::pro_version_is_activated()) {
+                $licensekeydesc = "<p style='color: green; font-weight: bold'>"
+                    . get_string('license_activated', 'mod_mooduell')
+                    . $expirationdate
+                    . ")</p>";
+            }
         } else {
             $licensekeydesc = "<p style='color: red; font-weight: bold'>"
                 . get_string('license_invalid', 'mod_mooduell')