Skip to content

Commit 599ee6a

Browse files
committed
Linting: linting code
1 parent ad28ee6 commit 599ee6a

File tree

2 files changed

+1
-17
lines changed

2 files changed

+1
-17
lines changed

tests/usecases/competencies/chris_drops_out_via_cohort_test.php

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,7 @@
2323
use core_competency\user_competency;
2424
use local_taskflow\event\rule_created_updated;
2525
use local_taskflow\local\assignment_status\assignment_status_facade;
26-
use local_taskflow\local\external_adapter\external_api_base;
2726
use local_taskflow\local\external_adapter\external_api_repository;
28-
use local_taskflow\local\rules\rules;
2927
use mod_booking\singleton_service;
3028
use stdClass;
3129
use tool_mocktesttime\time_mock;
@@ -660,7 +658,7 @@ public function test_chris_change_after_completion($bdata): void {
660658
$option = singleton_service::get_instance_of_booking_option($settings->cmid, $settings->id);
661659
$plugingeneratortf = self::getDataGenerator()->get_plugin_generator('local_taskflow');
662660
$plugingeneratortf->runtaskswithintime($cronlock, $lock, time());
663-
661+
664662
$userbertaid = $DB->get_record('user', ['firstname' => 'Berta'])->id;
665663
$userchrisemail = $DB->get_record('user', ['firstname' => 'Chris'])->email;
666664
$userbertaemail = $DB->get_record('user', ['firstname' => 'Berta'])->email;
@@ -717,7 +715,6 @@ public function test_chris_change_after_completion($bdata): void {
717715
$assignment = $DB->get_record('local_taskflow_assignment', ['userid' => $userchrisid]);
718716
$this->assertSame((int)$assignment->status, assignment_status_facade::get_status_identifier('completed'));
719717

720-
721718
$user = $DB->get_record('user', ['firstname' => 'Chris']);
722719
profile_load_custom_fields($user);
723720
$user->profile_field_orgunit = $user->profile['orgunit'] . '\\' . $secondcohort->name;

tests/usecases/competencies/garry_gone_test.php

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -17,23 +17,13 @@
1717
namespace taskflowadapter_ksw\usecases\competencies;
1818

1919
use advanced_testcase;
20-
use core_user;
21-
use DateTime;
2220
use local_taskflow\local\external_adapter\external_api_base;
2321
use local_taskflow\local\external_adapter\external_api_repository;
24-
use local_taskflow\local\rules\rules;
2522
use local_taskflow\plugininfo\taskflowadapter;
2623
use tool_mocktesttime\time_mock;
2724
use context_system;
28-
use core_competency\api;
29-
use core_competency\competency;
30-
use core_competency\user_competency;
3125
use local_taskflow\event\rule_created_updated;
3226
use local_taskflow\local\assignment_status\assignment_status_facade;
33-
use mod_booking\singleton_service;
34-
use stdClass;
35-
use mod_booking_generator;
36-
use function PHPUnit\Framework\assertSame;
3727

3828
/**
3929
* Tests for booking rules.
@@ -356,8 +346,5 @@ public function test_garry_gone(): void {
356346

357347
$assignment = $DB->get_record('local_taskflow_assignment', ['userid' => $user1->id]);
358348

359-
// Not yet implemented in KSW.
360-
// $this->assertSame(assignment_status_facade::get_status_identifier('assigned'), (int)$assignment->status);
361-
// $this->assertSame($now + 86400 * 420, (int)$assignment->duedate); // Its 420 days in the future.
362349
}
363350
}

0 commit comments

Comments
 (0)