Circular reference between $server and the connection event listener causes garbage collection cycles after resolving

Author: lucasnetau

src/Factory.php

@@ -213,9 +213,11 @@ static function (ConnectionInterface $connection) use ($server, $resolve, $rejec
                         return Promise\reject(new RuntimeException('Handshake failed'));
                     })->then(static function (MessengerInterface $messenger) use ($server, $resolve): void {
                         $server->close();
+                        $server->removeAllListeners('connection');
                         $resolve($messenger);
                     }, static function (Throwable $throwable) use ($server, $reject): void {
                         $server->close();
+                        $server->removeAllListeners();
                         $reject($throwable);
                     });
                 }
@@ -227,6 +229,7 @@ static function (ConnectionInterface $connection) use ($server, $resolve, $rejec
             $process->start($loop);
         }, static function () use ($server, $process): void {
             $server->close();
+            $server->removeAllListeners();
             $process->terminate();
         }))->then(static function (Messenger $messenger) use ($loop, $process): Messenger {
             $loop->addPeriodicTimer(self::INTERVAL, static function (TimerInterface $timer) use ($messenger, $loop, $process): void {

tests/FactoryTest.php

@@ -56,4 +56,18 @@ static function (MessengerInterface $messenger): PromiseInterface {
         );
         self::assertSame(['foo' => 'bar'], $payload->getPayload());
     }
+
+    public function testNoGarbageCollectionAfterSuccessfulRun(): void
+    {
+        \gc_collect_cycles();
+        $payload = await(
+            Factory::parentFromClass(ReturnChild::class, $this->loop)->then(
+                static function (MessengerInterface $messenger): PromiseInterface {
+                    return $messenger->rpc(MessagesFactory::rpc('return', ['foo' => 'bar']));
+                }
+            ),
+            $this->loop
+        );
+        $this->assertSame(0, \gc_collect_cycles());
+    }
 }