Solve some open sonarqube issues (#76)

* Fix some sonarqube issues

* Add sonarlint connected mode config

Author: X-rays5

.sonarlint/connectedMode.json

@@ -0,0 +1,5 @@
+{
+    "sonarCloudOrganization": "x-rays5",
+    "projectKey": "X-rays5_gta_base",
+    "region": "EU"
+}

common/src/conversion/hex.cpp

@@ -9,9 +9,7 @@ namespace base::common::conversion {
     if (!addr)
       return "0x0";
 
-    std::ostringstream stream;
-    stream << "0x" << std::hex << std::uppercase << addr;
-    return stream.str();
+    return std::format("0x{:X}", addr);
   }
 
   struct HexToIntTable {

common/src/globals.hpp

@@ -6,10 +6,10 @@
 #define GLOBALS_HPP_02231200
 
 namespace base::common::globals {
-  constexpr static auto kBASE_NAME = "base";
-  constexpr static auto target_window_name = "";
-  constexpr static auto target_window_class = "grcWindow";
-  constexpr static auto target_process_name = "GTA5.exe";
+  constexpr static auto* kBASE_NAME = "base";
+  constexpr static auto* target_window_name = "";
+  constexpr static auto* target_window_class = "grcWindow";
+  constexpr static auto* target_process_name = "GTA5.exe";
 }
 
 #endif //GLOBALS_HPP_02231200

common/src/logging/logger.cpp

@@ -90,7 +90,7 @@ namespace base::common::logging {
       formatter->add_flag<ThreadIdFormatter>('N').set_pattern("[%T] [%^%l%$] [thread: %N] [%s:%#] %v");
       spdlog::set_formatter(std::move(formatter));
 
-      logger->set_error_handler([&](const std::string& err) {
+      logger->set_error_handler([&logger](const std::string& err) {
         logger->critical("spdlog: {}", err);
       });
 

injector/src/main.cpp

@@ -48,7 +48,7 @@ void DoFrame(const base::injector::Window& window) {
           ImGui::Text(!game_wnd ? "Game not running" : fmt::format("Game running: {}", base::win32::GetPIDFromHWND(game_wnd).value_or(0)).c_str());
           if (game_wnd) {
             if (ImGui::Button("Inject")) {
-              auto _ = std::async(std::launch::async, [=]() {
+              auto _ = std::async(std::launch::async, [game_wnd]() {
                 if (const auto res = base::injector::Inject(base::win32::GetPIDFromHWND(game_wnd).value_or(0), kSETTINGS.dll_path); res.error()) {
                   LOG_ERROR("Failed to inject: {}", res.error());
                   MessageBoxA(nullptr, res.error().GetResultMessage().c_str(), "Error", MB_OK | MB_ICONERROR);

menu/src/memory/signature/batch.cpp

@@ -38,7 +38,7 @@ namespace base::menu::memory::signature {
 
     std::vector<std::future<bool>> futures;
     for (auto&& job : std::views::values(patterns_)) {
-      futures.emplace_back(util::kTHREAD_POOL->emplace_back([&] {
+      futures.emplace_back(util::kTHREAD_POOL->emplace_back([&profile, &job]() {
         profile.Begin(job.name);
         const auto res = ScanPattern(job);
         profile.End(job.name);