Memory leak after active switching between graphic and text TTY

[GermanAizek]

version

25.0.0.X

Describe

Im tested on latest release Xorg and Xlibre.

I have not yet found out the exact reason, but I assume that it is DRI2 with the DRI2ScreenInit function, perhaps it has a memory leak during initialization i965 driver.

Video:

https://jumpshare.com/s/YJgVNc4nKNzRxrLd4wTA

simplescreenrecorder_compress.mp4

Steps to reproduce

for i in $(seq 1 2000); do
    # switch to graphic VT7
    sudo chvt 7
    # switch to text VT1
    sudo chvt 1
done
# after execute 2000 iteration xorg eat ~200mb

[GermanAizek]

haha im sorry i found problem. see on comment

/* FIXME dri2_probe_driver_name() returns a strdup-ed string,
 * currently this gets leaked */

in

xserver/hw/xfree86/dri2/dri2.c

Lines 1602 to 1623 in 40f0a42

	if (info->version == 3 || info->numDrivers == 0) {
	/* Driver too old: use the old-style driverName field */
	ds->numDrivers = info->driverName ? 1 : 2;
	ds->driverNames = calloc(ds->numDrivers, sizeof(*ds->driverNames));
	if (!ds->driverNames)
	goto err_out;
	if (info->driverName) {
	ds->driverNames[0] = info->driverName;
	} else {
	/* FIXME dri2_probe_driver_name() returns a strdup-ed string,
	* currently this gets leaked */
	ds->driverNames[0] = ds->driverNames[1] = dri2_probe_driver_name(pScreen, info);
	if (!ds->driverNames[0])
	return FALSE;
	/* There is no VDPAU driver for i965, fallback to the generic
	* OpenGL/VAAPI va_gl backend to emulate VDPAU on i965. */
	if (strcmp(ds->driverNames[0], "i965") == 0)
	ds->driverNames[1] = "va_gl";
	}
	}

[GermanAizek]

Hotfix with PR #1414

I tested on a virtual machine and simulated hardware.