dix: unexport screenIsSaved and HasSaverWindow() #1381
Merged
+12
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These aren't used by any external drivers, so no need to keep them public. Signed-off-by: Enrico Weigelt, metux IT consult <[email protected]>
metux
requested review from
a team,
ONykyf,
algrid,
b-aaz,
callmetango,
cepelinas9000,
jonhermansen,
josephcrowell,
mikedld and
stefan11111
metux
added a commit
that referenced
this pull request
Nov 10, 2025
metux
added a commit
that referenced
this pull request
Nov 10, 2025
metux
added a commit
that referenced
this pull request
Nov 11, 2025
metux
added a commit
that referenced
this pull request
Nov 11, 2025
metux
added a commit
that referenced
this pull request
Nov 12, 2025
metux
added a commit
that referenced
this pull request
Nov 12, 2025
metux
added a commit
that referenced
this pull request
Nov 18, 2025
stefan11111
reviewed
Nov 19, 2025
|
|
||
| extern int screenIsSaved; | ||
|
|
||
| static inline bool HasSaverWindow(ScreenPtr pScreen) { |
Contributor
There was a problem hiding this comment.
Is there any reason to not keep this a macro?
metux
added a commit
that referenced
this pull request
Nov 19, 2025
metux
added a commit
that referenced
this pull request
Nov 19, 2025
metux
added a commit
that referenced
this pull request
Nov 19, 2025
metux
added a commit
that referenced
this pull request
Nov 19, 2025
metux
added a commit
that referenced
this pull request
Nov 19, 2025
metux
added a commit
that referenced
this pull request
Nov 20, 2025
metux
added a commit
that referenced
this pull request
Nov 20, 2025
metux
added a commit
that referenced
this pull request
Nov 20, 2025
metux
added a commit
that referenced
this pull request
Nov 20, 2025
metux
added a commit
that referenced
this pull request
Nov 20, 2025
metux
added a commit
that referenced
this pull request
Nov 20, 2025
metux
added a commit
that referenced
this pull request
Nov 20, 2025
metux
added a commit
that referenced
this pull request
Nov 20, 2025
metux
added a commit
that referenced
this pull request
Nov 20, 2025
stefan11111
approved these changes
Nov 20, 2025
metux
deleted the
pr/dix-unexport-screenissaved-and-hassaverwindow-_2025-11-10_14-01-32
branch
Contributor
|
@metux Btw, what's with all the Null* defines? (NullWindow, etc). |
metux
added a commit
that referenced
this pull request
Nov 20, 2025
Contributor
Author
Perhaps somebody felt it was better to have "typed" NULL values. Personally, I don't see any actual need for them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These aren't used by any external drivers, so no need to keep them public.
Signed-off-by: Enrico Weigelt, metux IT consult [email protected]