From 60ae5022d3bb605d7fc95115e86c493bde2c7425 Mon Sep 17 00:00:00 2001 From: "Enrico Weigelt, metux IT consult" Date: Mon, 10 Nov 2025 13:56:59 +0100 Subject: [PATCH] dix: unexport several extension related functions These aren't used (neither supposed to be used) by any drivers, so no need to keep them public. Signed-off-by: Enrico Weigelt, metux IT consult --- Xext/geext.c | 1 + Xext/xtest.c | 3 ++- Xi/sendexev.c | 1 + dix/extension_priv.h | 8 ++++++++ dix/main.c | 1 + dix/privates.c | 1 + dix/registry.c | 1 + dix/swaprep.c | 1 + dix/swapreq.c | 1 + dix/tables.c | 1 + include/extension.h | 7 ------- include/extnsionst.h | 6 ------ mi/miinitext.c | 1 + os/utils.c | 1 + 14 files changed, 20 insertions(+), 14 deletions(-) diff --git a/Xext/geext.c b/Xext/geext.c index 7c4eaece68..1bc973452b 100644 --- a/Xext/geext.c +++ b/Xext/geext.c @@ -28,6 +28,7 @@ #include #include +#include "dix/extension_priv.h" #include "dix/dix_priv.h" #include "dix/request_priv.h" #include "miext/extinit_priv.h" diff --git a/Xext/xtest.c b/Xext/xtest.c index 332bc197a1..cd20688e42 100644 --- a/Xext/xtest.c +++ b/Xext/xtest.c @@ -35,9 +35,10 @@ #include #include -#include "dix/input_priv.h" #include "dix/dix_priv.h" #include "dix/exevents_priv.h" +#include "dix/extension_priv.h" +#include "dix/input_priv.h" #include "dix/inpututils_priv.h" #include "dix/request_priv.h" #include "mi/mi_priv.h" diff --git a/Xi/sendexev.c b/Xi/sendexev.c index 7eac7d3ef8..0172fd48fc 100644 --- a/Xi/sendexev.c +++ b/Xi/sendexev.c @@ -56,6 +56,7 @@ SOFTWARE. #include #include "dix/exevents_priv.h" +#include "dix/extension_priv.h" #include "Xi/handlers.h" #include "inputstr.h" /* DeviceIntPtr */ diff --git a/dix/extension_priv.h b/dix/extension_priv.h index bcd2170501..03fd757e70 100644 --- a/dix/extension_priv.h +++ b/dix/extension_priv.h @@ -58,4 +58,12 @@ typedef struct { extern CallbackListPtr ExtensionAccessCallback; extern CallbackListPtr ExtensionDispatchCallback; +void EnableDisableExtensionError(const char *name, Bool enable); +void InitExtensions(int argc, char **argv); +void CloseDownExtensions(void); + +ExtensionEntry *GetExtensionEntry(int major); + +void NotImplemented(xEvent *, xEvent *) _X_NORETURN; + #endif /* _XSERVER_EXTENSION_PRIV_H */ diff --git a/dix/main.c b/dix/main.c index ee3fccab53..eafb8dd612 100644 --- a/dix/main.c +++ b/dix/main.c @@ -89,6 +89,7 @@ Equipment Corporation. #include "dix/callback_priv.h" #include "dix/cursor_priv.h" #include "dix/dix_priv.h" +#include "dix/extension_priv.h" #include "dix/input_priv.h" #include "dix/gc_priv.h" #include "dix/registry_priv.h" diff --git a/dix/privates.c b/dix/privates.c index ebcb964297..28c23b29a8 100644 --- a/dix/privates.c +++ b/dix/privates.c @@ -53,6 +53,7 @@ from The Open Group. #include #include "dix/colormap_priv.h" +#include "dix/extension_priv.h" #include "dix/screenint_priv.h" #include "windowstr.h" diff --git a/dix/registry.c b/dix/registry.c index cfe851eed5..c693124eec 100644 --- a/dix/registry.c +++ b/dix/registry.c @@ -24,6 +24,7 @@ CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. #include #include +#include "dix/extension_priv.h" #include "dix/registry_priv.h" #include "resource.h" diff --git a/dix/swaprep.c b/dix/swaprep.c index 78b9074d8e..062e11271d 100644 --- a/dix/swaprep.c +++ b/dix/swaprep.c @@ -51,6 +51,7 @@ SOFTWARE. #include #include "dix/dix_priv.h" +#include "dix/extension_priv.h" #include "misc.h" #include "dixstruct.h" diff --git a/dix/swapreq.c b/dix/swapreq.c index a7a4f6b53e..f20d798097 100644 --- a/dix/swapreq.c +++ b/dix/swapreq.c @@ -50,6 +50,7 @@ SOFTWARE. #include #include +#include "dix/extension_priv.h" #include "dix/reqhandlers_priv.h" #include "misc.h" diff --git a/dix/tables.c b/dix/tables.c index fcf948f0ba..71bb196b57 100644 --- a/dix/tables.c +++ b/dix/tables.c @@ -50,6 +50,7 @@ SOFTWARE. #include #include "dix/dix_priv.h" +#include "dix/extension_priv.h" #include "dix/reqhandlers_priv.h" #include "windowstr.h" diff --git a/include/extension.h b/include/extension.h index a4c09dee1e..4db26c5509 100644 --- a/include/extension.h +++ b/include/extension.h @@ -90,13 +90,6 @@ extern _X_EXPORT unsigned short StandardMinorOpcode(ClientPtr /*client */ ); extern _X_EXPORT Bool EnableDisableExtension(const char *name, Bool enable); -extern _X_EXPORT void EnableDisableExtensionError(const char *name, - Bool enable); - -extern _X_EXPORT void InitExtensions(int argc, char **argv); - -extern _X_EXPORT void CloseDownExtensions(void); - extern _X_EXPORT void LoadExtensionList(const ExtensionModule ext[], int listSize, Bool external); diff --git a/include/extnsionst.h b/include/extnsionst.h index 80c5423395..32ef1f37fd 100644 --- a/include/extnsionst.h +++ b/include/extnsionst.h @@ -79,10 +79,6 @@ typedef void (*EventSwapPtr) (xEvent *, xEvent *); extern _X_EXPORT EventSwapPtr EventSwapVector[128]; -extern _X_EXPORT void -NotImplemented( /* FIXME: this may move to another file... */ - xEvent *, xEvent *) _X_NORETURN; - extern _X_EXPORT ExtensionEntry * AddExtension(const char * /*name */ , int /*NumEvents */ , @@ -95,7 +91,5 @@ AddExtension(const char * /*name */ , extern _X_EXPORT ExtensionEntry * CheckExtension(const char *extname); -extern _X_EXPORT ExtensionEntry * -GetExtensionEntry(int major); #endif /* EXTENSIONSTRUCT_H */ diff --git a/mi/miinitext.c b/mi/miinitext.c index da6df88e40..092ac2a558 100644 --- a/mi/miinitext.c +++ b/mi/miinitext.c @@ -88,6 +88,7 @@ SOFTWARE. #undef CONFIG_MITSHM #endif +#include "dix/extension_priv.h" #include "miext/extinit_priv.h" #include "misc.h" diff --git a/os/utils.c b/os/utils.c index 52f9bf9c16..58a4259e67 100644 --- a/os/utils.c +++ b/os/utils.c @@ -95,6 +95,7 @@ OR PERFORMANCE OF THIS SOFTWARE. #endif #include "dix/dix_priv.h" +#include "dix/extension_priv.h" #include "dix/input_priv.h" #include "dix/screensaver_priv.h" #include "miext/extinit_priv.h"