From 4ef917a7fc3d2946e5204a6d783c795b5c67f04c Mon Sep 17 00:00:00 2001
From: Herman Semenoff <GermanAizek@yandex.ru>
Date: Sun, 16 Nov 2025 05:23:52 +0300
Subject: [PATCH] dri2: fix old memory leak during screen init with i965

Changes:
- Result of dri2_probe_driver_name is saved to the temporary variable driver_name
- ds->driverNames[0] always gets this pointer
- ds->driverNames[1] gets either the string literal "va_gl" or the same pointer driver_name
---
 hw/xfree86/dri2/dri2.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/hw/xfree86/dri2/dri2.c b/hw/xfree86/dri2/dri2.c
index f55659b53e..3e366398a9 100644
--- a/hw/xfree86/dri2/dri2.c
+++ b/hw/xfree86/dri2/dri2.c
@@ -1609,16 +1609,18 @@ DRI2ScreenInit(ScreenPtr pScreen, DRI2InfoPtr info)
         if (info->driverName) {
             ds->driverNames[0] = info->driverName;
         } else {
-            /* FIXME dri2_probe_driver_name() returns a strdup-ed string,
-             * currently this gets leaked */
-            ds->driverNames[0] = ds->driverNames[1] = dri2_probe_driver_name(pScreen, info);
-            if (!ds->driverNames[0])
+            char *driver_name = dri2_probe_driver_name(pScreen, info);
+
+            if (!driver_name)
                 return FALSE;
 
+            ds->driverNames[0] = driver_name;
             /* There is no VDPAU driver for i965, fallback to the generic
              * OpenGL/VAAPI va_gl backend to emulate VDPAU on i965. */
-            if (strcmp(ds->driverNames[0], "i965") == 0)
+            if (strcmp(driver_name, "i965") == 0)
                 ds->driverNames[1] = "va_gl";
+            else
+                ds->driverNames[1] = driver_name;
         }
     }
     else {