Skip to content

octocrab::Error: don't include unconditional backtrace in Display impl #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

octocrab::Error: don't include unconditional backtrace in Display impl #824

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ pub enum Error {
backtrace: Backtrace,
},

#[snafu(display("HTTP Error: {}\n\nFound at {}", source, backtrace))]
#[snafu(display("HTTP Error: {}", source))]
Http {
source: http::Error,
backtrace: Backtrace,
Expand All @@ -59,35 +59,35 @@ pub enum Error {
backtrace: Backtrace,
},

#[snafu(display("Service Error: {}\n\nFound at {}", source, backtrace))]
#[snafu(display("Service Error: {}", source))]
Service {
source: BoxError,
backtrace: Backtrace,
},

#[snafu(display("Hyper Error: {}\n\nFound at {}", source, backtrace))]
#[snafu(display("Hyper Error: {}", source))]
Hyper {
source: hyper::Error,
backtrace: Backtrace,
},

#[snafu(display("Serde Url Encode Error: {}\nFound at {}", source, backtrace))]
#[snafu(display("Serde Url Encode Error: {}", source))]
SerdeUrlEncoded {
source: serde_urlencoded::ser::Error,
backtrace: Backtrace,
},

#[snafu(display("Serde Error: {}\nFound at {}", source, backtrace))]
#[snafu(display("Serde Error: {}", source))]
Serde {
source: serde_json::Error,
backtrace: Backtrace,
},
#[snafu(display("JSON Error in {}: {}\nFound at {}", source.path(), source.inner(), backtrace))]
#[snafu(display("JSON Error in {}: {}", source.path(), source.inner()))]
Json {
source: serde_path_to_error::Error<serde_json::Error>,
backtrace: Backtrace,
},
#[snafu(display("JWT Error in {}\nFound at {}", source, backtrace))]
#[snafu(display("JWT Error in {}", source))]
JWT {
source: jsonwebtoken::errors::Error,
backtrace: Backtrace,
Expand Down