Merge tag '5.4.1' into develop

[FIX] incorrect faulty implementation of `isSecret` property of vlaidatable value

Author: maximkhatskevich

Sources/Core/3_Value/*SomeValidatableValue.swift

@@ -38,6 +38,9 @@ protocol SomeValidatableValue: DisplayNamed
 
     associatedtype Valid: Codable
 
+    static
+    var isSecret: Bool { get }
+    
     /// Helps identify whatever given value considered as empty.
     static
     func isEmpty(rawValue: Raw) -> Bool
@@ -60,12 +63,29 @@ protocol SomeValidatableValue: DisplayNamed
 
 // MARK: - Default implementations
 
+public
+extension SomeValidatableValue where Self: IsSecretValue
+{
+    static
+    var isSecret: Bool
+    {
+        true
+    }
+}
+
 public
 extension SomeValidatableValue
 {
     static
-    var isSecret: Bool { self is IsSecretValue }
-    
+    var isSecret: Bool
+    {
+        false
+    }
+}
+
+public
+extension SomeValidatableValue
+{
     static
     var conditionsOnRaw: [Condition<Raw>] { [] }
 

Sources/Core/Helpers/IsSecretValue.swift

@@ -1,4 +1,4 @@
 /// Semantic marker for value that should be displayed in
 /// a field with `isSecure` property set to `true`.
 public
-protocol IsSecretValue {}
+protocol IsSecretValue: SomeValidatableValue {}

Tests/AllTests/ValidatableValueTests.swift

@@ -168,4 +168,22 @@ extension SpecTests
         XCTAssert(ColorPreference.convert(rawValue: "white") == .white)
         XCTAssertNil(ColorPreference.convert(rawValue: "sdfsdf"))
     }
+    
+    func test_value_isSecret()
+    {
+        enum LastName: SomeValidatableValue
+        {
+            typealias Raw = String
+            typealias Valid = String
+        }
+        
+        enum Pwd: SomeValidatableValue, IsSecretValue
+        {
+            typealias Raw = String
+            typealias Valid = String
+        }
+        
+        XCTAssertFalse(NonRequired<LastName>("").metadata.isSecret)
+        XCTAssertTrue(NonRequired<Pwd>("").metadata.isSecret)
+    }
 }