Skip to content

Commit ef511d0

Browse files
LucasMLKclaude
andcommitted
fix: Correct Windows library name from randomx.dll to librandomx.dll
MinGW Makefiles with BUILD_SHARED_LIBS=ON automatically adds the 'lib' prefix to shared libraries, producing 'librandomx.dll' instead of 'randomx.dll'. This fix updates the GitHub Actions workflow and all documentation to reflect the actual CMake output. Changes: - GitHub Actions workflow: Update source_lib to 'librandomx.dll' - CLAUDE.md: Update Windows build command to use librandomx.dll - README.md: Update Windows build command to use librandomx.dll This aligns Windows naming with Linux (librandomx.so) and macOS (librandomx.dylib) conventions, ensuring consistency across all platforms. Fixes: GitHub Actions Windows build failure Closes: #[issue_number_if_applicable] 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
1 parent 8517ebb commit ef511d0

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

.github/workflows/build-and-release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ jobs:
3939
cmake_args: '-G "MinGW Makefiles" -DCMAKE_BUILD_TYPE=Release -DARCH=native -DBUILD_SHARED_LIBS=ON'
4040
artifact_name: 'librandomx_windows_x86_64.dll'
4141
output_lib: 'librandomx_windows_x86_64.dll'
42-
source_lib: 'randomx.dll'
42+
source_lib: 'librandomx.dll'
4343

4444
steps:
4545
- name: Checkout code

CLAUDE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ cd randomx
6060
mkdir build && cd build
6161
cmake .. -G "MinGW Makefiles" -DCMAKE_BUILD_TYPE=Release -DARCH=native -DBUILD_SHARED_LIBS=ON
6262
make -j4
63-
cp -i randomx.dll ../../src/main/resources/native/librandomx_windows_x86_64.dll
63+
cp -i librandomx.dll ../../src/main/resources/native/librandomx_windows_x86_64.dll
6464
cd ../..
6565
```
6666

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ cd randomx
9898
mkdir build && cd build
9999
cmake .. -G "MinGW Makefiles" -DCMAKE_BUILD_TYPE=Release -DARCH=native -DBUILD_SHARED_LIBS=ON
100100
make -j4
101-
cp -i randomx.dll ../../src/main/resources/native/librandomx_windows_x86_64.dll
101+
cp -i librandomx.dll ../../src/main/resources/native/librandomx_windows_x86_64.dll
102102
```
103103
You can also compile using Visual Studio, as the official RandomX repository provides solution files.
104104

0 commit comments

Comments
 (0)