Fixed some code review feedback:

- Removed the SB completion check
- Removed extraneous SQL logging

Author: matthewhillier

README.md

@@ -75,7 +75,7 @@ Follow these steps to setup XIVStats-Gatherer-Java:
   |-d            | --database            | String         | database name                                                        |
   |-D            | --do-not-store-date   | none           | do not store date of last player activity                            |
   |-f            | --finish              | integer        | the character id to conclude character run at (inclusive)            |
-  |-F            | --print-failures      | none           | print records that don't exist                                      |
+  |-F            | --print-failures      | none           | print records that don't exist                                       |
   |-h            | --help                | none           | display help message                                                 |
   |-m            | --store-mounts        | none           | store mount data set for each player into the database               |
   |-P            | --store-minions       | none           | store minion data set for each player into the database              |
@@ -188,9 +188,6 @@ The database table ```tblplayers``` has the following structure:
 |hw_complete           |bit      |Mount - Midgardsormr            |
 |hw_31_complete        |bit      |Minion - Wind-up Haurchefant    |
 |hw_33_complete        |bit      |Minion - Wind-up Aymeric        |
-|sb_complete           |bit      |Minion - Ivon Coeurlfist Doll   |
-|                      |         |Minion - Dress-up Yugiri        |
-|                      |         |Wind-up Exdeath                 |
 |legacy_player         |bit      |Mount - Legacy Chocobo          |
 |*mounts*              |*text*   |*N/A*                           |
 |*minions*             |*text*   |*N/A*                           |

src/main/java/com/ffxivcensus/gatherer/GathererController.java

@@ -357,7 +357,7 @@ private void createTable(String tableName) {
                 sbSQL.append("topazcarubuncleplush BIT,emeraldcarbuncleplush BIT,");
                 sbSQL.append("hildibrand BIT, dideternalbond BIT, arrcollector BIT,");
                 sbSQL.append("kobold BIT, sahagin BIT, amaljaa BIT, sylph BIT,  moogle BIT, vanuvanu BIT, vath BIT,");
-                sbSQL.append("arr_25_complete BIT,hw_complete BIT, hw_31_complete BIT, hw_33_complete BIT, sb_complete BIT, legacy_player BIT");
+                sbSQL.append("arr_25_complete BIT,hw_complete BIT, hw_31_complete BIT, hw_33_complete BIT, legacy_player BIT");
             }
             if (this.storeMounts) {
                 sbSQL.append(",mounts TEXT");
@@ -534,13 +534,13 @@ protected String writeToDB(Player player) {
                                 + player.getBitHasEmeraldCarbunclePlush() + ",");
 
                 sbFields.append("hildibrand, ps4collectors, dideternalbond, arrcollector, kobold, sahagin, amaljaa, "
-                                + "sylph, moogle, vanuvanu, vath, hw_complete, hw_31_complete, hw_33_complete, sb_complete, legacy_player");
+                                + "sylph, moogle, vanuvanu, vath, hw_complete, hw_31_complete, hw_33_complete, legacy_player");
                 sbValues.append(player.getBitHasCompletedHildibrand() + "," + player.getBitHasPS4Collectors() + ","
                         + player.getBitHasEternalBond() + "," + player.getBitHasARRCollectors() + ","
                         + player.getBitHasKobold() + "," + player.getBitHasSahagin() + "," + player.getBitHasAmaljaa() + ","
                         + player.getBitHasSylph() + "," + player.getBitHasMoogle() + "," + player.getBitHasVanuVanu() + ","
                         + player.getBitHasVath() + "," + player.getBitHasCompletedHW() + ","
-                        + player.getBitHasCompleted3pt1() + "," + player.getBitHasCompleted3pt3() + "," + player.getBitHasCompletedSB() +","
+                        + player.getBitHasCompleted3pt1() + "," + player.getBitHasCompleted3pt3() + ","
                         + player.getBitIsLegacyPlayer());
 
             }
@@ -581,7 +581,7 @@ protected String writeToDB(Player player) {
             sbValues.append(");");
 
             String strSQL = sbFields.toString() + sbValues.toString();
-            System.out.println(strSQL);
+
             st.executeUpdate(strSQL);
             if(!this.quiet || this.isVerbose()) {
                 strOut = "Character " + player.getId() + " written to database successfully.";

src/main/java/com/ffxivcensus/gatherer/Player.java

@@ -107,7 +107,6 @@ public class Player {
     private boolean hasVanuVanu;
     private boolean hasVath;
     private boolean hasCompletedHW;
-    private boolean hasCompletedSB;
     private boolean hasCompleted3pt1;
     private boolean hasCompleted3pt3;
     private boolean isLegacyPlayer;
@@ -1996,10 +1995,6 @@ public static Player getPlayer(int playerID, int attempt) throws Exception {
             player.setHasVanuVanu(player.doesPlayerHaveMount("Sanuwa"));
             player.setHasVath(player.doesPlayerHaveMount("Kongamato"));
             player.setHasCompletedHW(player.doesPlayerHaveMount("Midgardsormr"));
-            // Main Scenario quest doesn't drop a minion, so instead assume players will at least play one of the Level 70 dungeons and eventually get the minion
-            player.setHasCompletedSB(player.doesPlayerHaveMinion("Ivon Coeurlfist Doll") ||
-            		player.doesPlayerHaveMinion("Dress-up Yugiri") ||
-            		player.doesPlayerHaveMinion("Wind-up Exdeath"));
             player.setIsLegacyPlayer(player.doesPlayerHaveMount("Legacy Chocobo"));
             player.setActive(player.isPlayerActiveInDateRange());
         } catch (IOException ioEx) {
@@ -2519,28 +2514,4 @@ public int getBitHasPreOrderSB() {
 	public void setHasPreOrderSB(boolean hasPreOrderSB) {
 		this.hasPreOrderSB = hasPreOrderSB;
 	}
-
-	/**
-	 * Get whether player has completed Stormblood.
-	 * @return whether player has completed Stromblood.
-	 */
-	public boolean isHasCompletedSB() {
-		return hasCompletedSB;
-	}
-
-	/**
-	 * Get whether player has completed Stormblood.
-	 * @return whether player has completed Stromblood.
-	 */
-	public int getBitHasCompletedSB() {
-		return isHasCompletedSB() ? 1 : 0;
-	}
-
-	/**
-	 * Set whether player has completed Stromblood.
-	 * @param hasCompletedSB whether player has completed Stormblood.
-	 */
-	public void setHasCompletedSB(boolean hasCompletedSB) {
-		this.hasCompletedSB = hasCompletedSB;
-	}
 }

src/test/java/com/ffxivcensus/gatherer/PlayerTest.java

@@ -143,10 +143,6 @@ public void testGetPlayer() throws Exception {
         assertEquals(1, playerOne.getBitHasSylph());
         assertTrue(playerOne.isHasCompletedHW());
         assertEquals(1, playerOne.getBitHasCompletedHW());
-        // Currently no way to definitively tell player has completed the SB Main Scenario
-        // Currently assumes minion drop from Kugane, Temple of the Fist or Delta V4
-        assertTrue(playerOne.isHasCompletedSB());
-        assertEquals(1, playerOne.getBitHasCompletedSB());
         assertTrue(playerOne.isHasCompleted3pt1());
         assertEquals(1, playerOne.getBitHasCompleted3pt1());
         assertFalse(playerOne.getIsLegacyPlayer());