feat(mf2)!: Drop u:locale option (unicode-org/message-format-wg#1012)

Author: XM5jDcsHTyGJtQqlCi

mf2/messageformat/src/resolve/format-markup.ts

@@ -14,7 +14,7 @@ export function formatMarkup(
   if (options?.size) {
     part.options = {};
     for (const [name, value] of options) {
-      if (name === 'u:dir' || name === 'u:locale') {
+      if (name === 'u:dir') {
         const msg = `The option ${name} is not valid for markup`;
         const optSource = getValueSource(value);
         ctx.onError(new MessageResolutionError('bad-option', msg, optSource));

mf2/messageformat/src/resolve/function-context.ts

@@ -6,31 +6,12 @@ import { Options } from '../data-model/types.ts';
 export class MessageFunctionContext {
   #ctx: Context;
   #litKeys: Set<string> | undefined;
-  #locales: Intl.Locale[];
   readonly dir: 'ltr' | 'rtl' | 'auto' | undefined;
   readonly id: string | undefined;
   readonly source: string;
   constructor(ctx: Context, source: string, options?: Options) {
     this.#ctx = ctx;
 
-    this.#locales = ctx.locales;
-    const localeOpt = options?.get('u:locale');
-    if (localeOpt) {
-      let rl = resolveValue(ctx, localeOpt);
-      try {
-        if (typeof rl === 'object' && typeof rl?.valueOf === 'function') {
-          rl = rl.valueOf();
-        }
-        this.#locales = Array.isArray(rl)
-          ? rl.map(lc => new Intl.Locale(lc))
-          : [new Intl.Locale(String(rl))];
-      } catch {
-        const msg = 'Unsupported value for u:locale option';
-        const optSource = getValueSource(localeOpt);
-        ctx.onError(new MessageResolutionError('bad-option', msg, optSource));
-      }
-    }
-
     this.dir = undefined;
     const dirOpt = options?.get('u:dir');
     if (dirOpt) {
@@ -66,7 +47,7 @@ export class MessageFunctionContext {
   }
 
   get locales() {
-    return this.#locales.map(String);
+    return this.#ctx.locales.map(String);
   }
 
   get onError() {

mf2/messageformat/src/resolve/function-ref.test.ts

@@ -62,18 +62,6 @@ describe('inputs with options', () => {
     });
     expect(parts).toEqual(nf.formatToParts(12345678));
   });
-
-  test('u:locale value take precedence', () => {
-    const mf = new MessageFormat(
-      'en',
-      '{$val :number minimumFractionDigits=2 u:locale=ar}'
-    );
-    const msg = mf.formatToParts({ val: 12345 });
-    const { parts } = msg[1] as MessageNumberPart;
-
-    const ar = new Intl.NumberFormat('ar', { minimumFractionDigits: 2 });
-    expect(parts).toEqual(ar.formatToParts(12345));
-  });
 });
 
 describe('Type casts based on runtime', () => {

mf2/messageformat/src/resolve/resolve-function-ref.ts

@@ -59,9 +59,7 @@ function resolveOptions(ctx: Context, options: Options | undefined) {
   const opt: Record<string, unknown> = Object.create(null);
   if (options) {
     for (const [name, value] of options) {
-      if (name !== 'u:dir' && name !== 'u:id' && name !== 'u:locale') {
-        opt[name] = resolveValue(ctx, value);
-      }
+      if (!name.startsWith('u:')) opt[name] = resolveValue(ctx, value);
     }
   }
   return opt;