Skip to content

Commit 92480f5

Browse files
authored
fix(translation): fix translation stored in const, to also be changed using language change button (#1403)
1 parent 04e48d7 commit 92480f5

File tree

4 files changed

+15
-14
lines changed

4 files changed

+15
-14
lines changed

yaki_admin/src/assets/translations/en.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@
5757
"statistics": "Statistics"
5858
},
5959
"popups": {
60-
"irreversible": "tThis action is irreversible !",
60+
"irreversible": "This action is irreversible !",
6161
"deletionConfirmation": "Are you sure you want to ",
6262
"fileHandling": {
6363
"tooLarge": "The file is too large",

yaki_admin/src/assets/translations/fr.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@
6060
"irreversible": "Cette action est irréversible !",
6161
"deletionConfirmation": "Êtes-vous sûr de vouloir ",
6262
"fileHandling": {
63-
"tooLarge": "Le fichier est trop volumineux",
63+
"tooLarge": "Fichier trop volumineux",
6464
"select": "Sélectionner un fichier",
6565
"sizeLimit": "sous 500kb",
6666
"wrongFormat": "Le format du fichier est incorrect"

yaki_admin/src/ui/components/modals/ModalCreateEditTeam.vue

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import pencilIcon from "@/assets/icons_svg/Edit.svg";
88
import deleteIcon from "@/assets/icons_svg/CrossClose.svg";
99
import defaultTeamImage from "@/assets/images/teamDefaultImg2.svg";
1010
11-
import { ref, watch } from "vue";
11+
import { computed, ref, watch } from "vue";
1212
1313
import { BUTTONCOLORS } from "@/constants/componentsSettings.enum";
1414
import { useModalStore } from "@/stores/modalStore";
@@ -20,14 +20,15 @@ const isMissingTeamNameError = ref<boolean>(false);
2020
2121
import { useI18n } from "vue-i18n";
2222
const { t } = useI18n();
23-
const createEditTranslation = {
23+
24+
const createEditTranslation = computed(() => ({
2425
modalTitleEditText: t("popups.teamEdition.title"),
2526
modalDescriptionEditText: t("popups.teamEdition.description"),
2627
modaleTitleCreateText: t("popups.teamCreation.title"),
2728
modalDescriptionCreateText: t("popups.teamCreation.description"),
2829
modalValidateButtonText: t("buttons.validate"),
2930
modalEditButtonText: t("buttons.modify"),
30-
};
31+
}));
3132
3233
const teamLogoStore = useTeamLogoStore();
3334
@@ -65,7 +66,7 @@ watch(
6566
[() => modalStore.getMode, () => modalStore.getIsShow],
6667
([newMode, newIsShow]) => {
6768
teamLogoStore.setTeamLogoToDisplay(newIsShow, newMode);
68-
modalStore.setModalHeaderText(newIsShow, newMode, createEditTranslation);
69+
modalStore.setModalHeaderText(newIsShow, newMode, createEditTranslation.value);
6970
7071
onModalOpenLogo.value = teamLogoStore.getLogoDisplayed;
7172
},

yaki_admin/src/ui/components/modals/ModalDelete.vue

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,34 +15,34 @@ const teamStore = useTeamStore();
1515
1616
import { useI18n } from "vue-i18n";
1717
const { t } = useI18n();
18-
const translation = {
18+
const translation = computed(() => ({
1919
remove: t("buttons.remove"),
2020
delete: t("buttons.delete"),
2121
userRemove: t("popups.teamRemoveUser.title"),
2222
captainRemove: t("popups.captainRemoval.title"),
2323
teamDelete: t("popups.teamDeletion.title"),
24-
};
24+
}));
2525
2626
const title = computed(() => {
2727
switch (modalStore.getMode) {
2828
case MODALMODE.userDelete:
29-
return translation.userRemove;
29+
return translation.value.userRemove;
3030
case MODALMODE.captainDelete:
31-
return translation.captainRemove;
31+
return translation.value.captainRemove;
3232
case MODALMODE.teamDelete:
33-
return translation.teamDelete;
33+
return translation.value.teamDelete;
3434
}
3535
return "";
3636
});
3737
3838
const action = computed(() => {
3939
switch (modalStore.getMode) {
4040
case MODALMODE.userDelete:
41-
return translation.remove;
41+
return translation.value.remove;
4242
case MODALMODE.captainDelete:
43-
return translation.remove;
43+
return translation.value.remove;
4444
case MODALMODE.teamDelete:
45-
return translation.delete;
45+
return translation.value.delete;
4646
}
4747
return "";
4848
});

0 commit comments

Comments
 (0)