Skip to content

Commit d2f0db3

Browse files
authored
fix(vacation_to_absence): change word vacation to absence in statistics because it can cause issues (#1419)
1 parent b730a04 commit d2f0db3

File tree

6 files changed

+359
-349
lines changed

6 files changed

+359
-349
lines changed

yaki_admin_backend/src/main/java/com/xpeho/yaki_admin_backend/data/services/StatisticsServiceImpl.java

Lines changed: 31 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,12 @@ public BasicStatisticsEntity getBasicStatistics(StatisticsRequestEntity requestE
3939
@Override
4040
public ArrayList<DeclarationsListEntity> getDeclarationsList(StatisticsRequestEntity requestEntity) {
4141
List<Object[]> results;
42-
if (requestEntity.teamId() == null || requestEntity.teamId() == 0){
43-
results = declarationJpaRepository.getDeclarationsListByCustomerId(requestEntity.periodStart(), requestEntity.periodEnd(), requestEntity.customerId());
42+
if (requestEntity.teamId() == null || requestEntity.teamId() == 0) {
43+
results = declarationJpaRepository.getDeclarationsListByCustomerId(requestEntity.periodStart(),
44+
requestEntity.periodEnd(), requestEntity.customerId());
4445
} else {
45-
results = declarationJpaRepository.getDeclarationsListByCustomerAndTeamId(requestEntity.periodStart(), requestEntity.periodEnd(), requestEntity.customerId(), requestEntity.teamId());
46+
results = declarationJpaRepository.getDeclarationsListByCustomerAndTeamId(requestEntity.periodStart(),
47+
requestEntity.periodEnd(), requestEntity.customerId(), requestEntity.teamId());
4648
}
4749

4850
ArrayList<DeclarationsListEntity> declarationsListEntities = new ArrayList<>();
@@ -51,9 +53,12 @@ public ArrayList<DeclarationsListEntity> getDeclarationsList(StatisticsRequestEn
5153
String firstName = result[1].toString();
5254
String lastName = result[2].toString();
5355
String declarationStatus = result[3].toString();
54-
LocalDateTime declarationDate = Instant.parse(result[4].toString()).atZone(ZoneId.systemDefault()).toLocalDateTime();
55-
LocalDateTime declarationDateStart = Instant.parse(result[5].toString()).atZone(ZoneId.systemDefault()).toLocalDateTime();
56-
LocalDateTime declarationDateEnd = Instant.parse(result[6].toString()).atZone(ZoneId.systemDefault()).toLocalDateTime();
56+
LocalDateTime declarationDate = Instant.parse(result[4].toString()).atZone(ZoneId.systemDefault())
57+
.toLocalDateTime();
58+
LocalDateTime declarationDateStart = Instant.parse(result[5].toString()).atZone(ZoneId.systemDefault())
59+
.toLocalDateTime();
60+
LocalDateTime declarationDateEnd = Instant.parse(result[6].toString()).atZone(ZoneId.systemDefault())
61+
.toLocalDateTime();
5762

5863
DeclarationsListEntity declarationsListEntity = new DeclarationsListEntity(
5964
teamName,
@@ -62,18 +67,19 @@ public ArrayList<DeclarationsListEntity> getDeclarationsList(StatisticsRequestEn
6267
declarationStatus,
6368
declarationDate,
6469
declarationDateStart,
65-
declarationDateEnd
66-
);
70+
declarationDateEnd);
6771
declarationsListEntities.add(declarationsListEntity);
6872
}
6973
return declarationsListEntities;
7074
}
7175

7276
@Override
7377
public GlobalStatisticsEntity getGlobalStatistics(StatisticsRequestEntity requestEntity) {
74-
List<Object[]> results = declarationJpaRepository.getGlobalStatisticsByCustomerId(requestEntity.periodStart(), requestEntity.periodEnd(), requestEntity.customerId());
78+
List<Object[]> results = declarationJpaRepository.getGlobalStatisticsByCustomerId(requestEntity.periodStart(),
79+
requestEntity.periodEnd(), requestEntity.customerId());
7580
if (results.isEmpty()) {
76-
throw new EntityNotFoundException("The global statistics for customer with id " + requestEntity.customerId() + " not found.");
81+
throw new EntityNotFoundException(
82+
"The global statistics for customer with id " + requestEntity.customerId() + " not found.");
7783
}
7884
Object[] result = results.get(0);
7985
double declarationCount = Double.parseDouble(result[0].toString());
@@ -83,17 +89,18 @@ public GlobalStatisticsEntity getGlobalStatistics(StatisticsRequestEntity reques
8389
return new GlobalStatisticsEntity(
8490
declarationCount,
8591
remoteCount,
86-
onsiteCount
87-
);
92+
onsiteCount);
8893
}
8994

9095
@Override
9196
public ArrayList<PerTeammateStatisticsEntity> getPerTeammateStatistics(StatisticsRequestEntity requestEntity) {
9297
List<Object[]> results;
93-
if (requestEntity.teamId() == null || requestEntity.teamId() == 0){
94-
results = declarationJpaRepository.getPerTeammateStatisticsByCustomerId(requestEntity.periodStart(), requestEntity.periodEnd(), requestEntity.customerId());
98+
if (requestEntity.teamId() == null || requestEntity.teamId() == 0) {
99+
results = declarationJpaRepository.getPerTeammateStatisticsByCustomerId(requestEntity.periodStart(),
100+
requestEntity.periodEnd(), requestEntity.customerId());
95101
} else {
96-
results = declarationJpaRepository.getPerTeammateStatisticsByCustomerAndTeamId(requestEntity.periodStart(), requestEntity.periodEnd(), requestEntity.customerId(), requestEntity.teamId());
102+
results = declarationJpaRepository.getPerTeammateStatisticsByCustomerAndTeamId(requestEntity.periodStart(),
103+
requestEntity.periodEnd(), requestEntity.customerId(), requestEntity.teamId());
97104
}
98105

99106
ArrayList<PerTeammateStatisticsEntity> perTeammateStatisticsEntities = new ArrayList<>();
@@ -103,24 +110,24 @@ public ArrayList<PerTeammateStatisticsEntity> getPerTeammateStatistics(Statistic
103110
double declarationCount = Double.parseDouble(result[3].toString());
104111
double remoteCount = Double.parseDouble(result[4].toString());
105112
double onsiteCount = Double.parseDouble(result[5].toString());
106-
double vacationCount = Double.parseDouble(result[6].toString());
113+
double absenceCount = Double.parseDouble(result[6].toString());
107114

108115
PerTeammateStatisticsEntity perTeammateStatisticsEntity = new PerTeammateStatisticsEntity(
109116
firstName,
110117
lastName,
111118
declarationCount,
112119
remoteCount,
113120
onsiteCount,
114-
vacationCount
115-
);
121+
absenceCount);
116122
perTeammateStatisticsEntities.add(perTeammateStatisticsEntity);
117123
}
118124
return perTeammateStatisticsEntities;
119125
}
120126

121127
@Override
122128
public ArrayList<PerTeamStatisticsEntity> getPerTeamStatistics(StatisticsRequestEntity requestEntity) {
123-
List<Object[]> results = declarationJpaRepository.getPerTeamStatisticsByCustomerId(requestEntity.periodStart(), requestEntity.periodEnd(), requestEntity.customerId());
129+
List<Object[]> results = declarationJpaRepository.getPerTeamStatisticsByCustomerId(requestEntity.periodStart(),
130+
requestEntity.periodEnd(), requestEntity.customerId());
124131

125132
ArrayList<PerTeamStatisticsEntity> perTeamStatisticsEntities = new ArrayList<>();
126133
for (Object[] result : results) {
@@ -133,32 +140,31 @@ public ArrayList<PerTeamStatisticsEntity> getPerTeamStatistics(StatisticsRequest
133140
teamName,
134141
declarationCount,
135142
remoteCount,
136-
onsiteCount
137-
);
143+
onsiteCount);
138144
perTeamStatisticsEntities.add(perTeamStatisticsEntity);
139145
}
140146
return perTeamStatisticsEntities;
141147
}
142148

143149
@Override
144150
public ArrayList<PerWeekdayStatisticsEntity> getPerWeekDayStatistics(StatisticsRequestEntity requestEntity) {
145-
List<Object[]> results = declarationJpaRepository.getPerWeekDayStatisticsByCustomerId(requestEntity.periodStart(), requestEntity.periodEnd(), requestEntity.customerId());
151+
List<Object[]> results = declarationJpaRepository.getPerWeekDayStatisticsByCustomerId(
152+
requestEntity.periodStart(), requestEntity.periodEnd(), requestEntity.customerId());
146153

147154
ArrayList<PerWeekdayStatisticsEntity> perWeekdayStatisticsEntities = new ArrayList<>();
148155
for (Object[] result : results) {
149156
String weekday = result[0].toString();
150157
double declarationCount = Double.parseDouble(result[1].toString());
151158
double remoteCount = Double.parseDouble(result[2].toString());
152159
double onsiteCount = Double.parseDouble(result[3].toString());
153-
double vacationCount = Double.parseDouble(result[4].toString());
160+
double absenceCount = Double.parseDouble(result[4].toString());
154161

155162
PerWeekdayStatisticsEntity perWeekdayStatisticsEntity = new PerWeekdayStatisticsEntity(
156163
weekday,
157164
declarationCount,
158165
remoteCount,
159166
onsiteCount,
160-
vacationCount
161-
);
167+
absenceCount);
162168
perWeekdayStatisticsEntities.add(perWeekdayStatisticsEntity);
163169
}
164170
return perWeekdayStatisticsEntities;

0 commit comments

Comments
 (0)