Skip to content

Commit 1ad1cfe

Browse files
authored
fix(emailMandatory): remove the email mandatory in the entity (#20)
1 parent 464fb4d commit 1ad1cfe

File tree

3 files changed

+14
-2
lines changed

3 files changed

+14
-2
lines changed

app/src/main/java/com/xpeho/xpeapp/data/model/agenda/AgendaBirthday.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,5 @@ data class AgendaBirthday(
77
val id: Int,
88
@SerializedName("first_name") val firstName: String,
99
val birthdate: Date,
10-
val email: String,
10+
val email: String?,
1111
)

app/src/main/java/com/xpeho/xpeapp/data/service/WordpressRepository.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ package com.xpeho.xpeapp.data.service
22

33
import android.util.Log
44
import androidx.annotation.VisibleForTesting
5-
import com.google.api.Page
65
import com.xpeho.xpeapp.data.entity.AuthentificationBody
76
import com.xpeho.xpeapp.data.entity.QvstAnswerBody
87
import com.xpeho.xpeapp.data.entity.QvstCampaignEntity

app/src/test/java/com/xpeho/xpeapp/data/WordpressRepositoryTest.kt

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -721,6 +721,19 @@ class WordpressRepositoryTest {
721721
assertEquals(birthdays, result)
722722
}
723723

724+
@Test
725+
fun `getAllBirthdays with valid response returns birthdays with email null`() = runBlocking {
726+
val birthdays = listOf(
727+
AgendaBirthday(1, "firstname", SimpleDateFormat("yyyy-MM-dd").
728+
parse("2023-01-01")!!, email = null)
729+
)
730+
coEvery { wordpressService.fetchBirthdays("page") } returns birthdays
731+
732+
val result = wordpressRepo.getAllBirthdays("page")
733+
734+
assertEquals(birthdays, result)
735+
}
736+
724737
@Test
725738
fun `getAllBirthdays with network error returns null`() = runBlocking {
726739
coEvery { wordpressService.fetchBirthdays("page") } throws UnknownHostException()

0 commit comments

Comments
 (0)