AOSP.patch is not written correctly

[cmclaudet]

Component

In the build instructions: https://github.com/XPRIZE/GLEXP-Team-onebillion/blob/master/BUILD.md

Description

Step 2.4, "Apply the AOSP/onecourse-AOSP.patch from the onecourse source repository to the AOSP source tree (current working folder)." does not work as expected as it seems the patch does not contain the correct paths to the files in question.
For example, in line 3 of AOSP/onecourse-AOSP.patch, a/target/product/full_base.mk should be a/build/target/product/full_base.mk. It is the same for all references to this file, and (seemingly) all other files referenced in the patch.
For some files it's possible to just correct the path used in the patch to that file, but for others there are multiple files with the same name but different paths in the whole repo. For example, BoardConfig.mk seems to appear around 30 times, so it's not clear which one of these the patch should apply to.

Severity

• High
  I assume without the patch it isn't possible to do step 2 of the build instructions.

[jo-xprize]

@cmclaudet Hi, Catherine. If you take a look at the file INSTALL-STANDALONE.md, you'll find instructions on how to build and install the onebillion software as a normal (standalone) Android app. This way you won't have to deal with the complexity of flashing filesystem images. Would you be able to use this installation method instead, or are you required to use filesystem images?

[cmclaudet]

Hi Jo, thanks for pointing me out to the standalone app installation instructions, I can definitely use them. It would be nice to be able to build the filesystem images, but having the standalone app is a great start. It may be an idea to have a look at the patch anyway for others who are interested in using it and for me if the need arises. Thanks!

…

On Tue, Jul 23, 2019 at 4:32 PM Jo @ XPRIZE ***@***.***> wrote: @cmclaudet <https://github.com/cmclaudet> Hi, Catherine. If you take a look at the file INSTALL-STANDALONE.md <https://github.com/XPRIZE/GLEXP-Team-onebillion/blob/master/INSTALL-STANDALONE.md>, you'll find instructions on how to build and install the onebillion software as a normal (standalone) Android app. This way you won't have to deal with the complexity of flashing filesystem images. Would you be able to use this installation method instead, or are you required to use filesystem images? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#19?email_source=notifications&email_token=AEIDF4PNPQFGLU3H5VKE37LQA4I73A5CNFSM4IGCGUFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2TJ65A#issuecomment-514236276>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEIDF4NQJKYAD4W6VYYFU53QA4I73ANCNFSM4IGCGUFA> .

[jo-xprize]

@cmclaudet Hi, Catherine. Were you able to follow the instructions in the INSTALL-STANDALONE.md file? Let us know if any of the steps are unclear so that we can assist you.

[cmclaudet]

Hi Jo, there was no problem following these install instructions. Thanks for your help!