Skip to content

Commit 56c1e07

Browse files
authored
fix: Correctly check for build_only when deciding whether to run tests (#5708)
This change modifies the `build_only` check used to determine whether to run tests. For easier debugging in the future it also prints out the contents of the strategy matrix.
1 parent afc0565 commit 56c1e07

File tree

2 files changed

+14
-1
lines changed

2 files changed

+14
-1
lines changed

.github/actions/build-test/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ runs:
7575
echo 'Verifying presence of instrumentation.'
7676
./rippled --version | grep libvoidstar
7777
- name: Test the binary
78-
if: ${{ inputs.build_only == 'true' }}
78+
if: ${{ inputs.build_only == 'false' }}
7979
shell: bash
8080
working-directory: ${{ inputs.build_dir }}/${{ inputs.os == 'windows' && inputs.build_type || '' }}
8181
run: |

.github/workflows/build-test.yml

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,19 @@ jobs:
8888
runs-on: ${{ matrix.architecture.runner }}
8989
container: ${{ inputs.os == 'linux' && format('ghcr.io/xrplf/ci/{0}-{1}:{2}-{3}', matrix.os.distro_name, matrix.os.distro_version, matrix.os.compiler_name, matrix.os.compiler_version) || null }}
9090
steps:
91+
- name: Check strategy matrix
92+
run: |
93+
echo 'Operating system distro name: ${{ matrix.os.distro_name }}'
94+
echo 'Operating system distro version: ${{ matrix.os.distro_version }}'
95+
echo 'Operating system compiler name: ${{ matrix.os.compiler_name }}'
96+
echo 'Operating system compiler version: ${{ matrix.os.compiler_version }}'
97+
echo 'Architecture platform: ${{ matrix.architecture.platform }}'
98+
echo 'Architecture runner: ${{ toJson(matrix.architecture.runner) }}'
99+
echo 'Build type: ${{ matrix.build_type }}'
100+
echo 'Build only: ${{ matrix.build_only }}'
101+
echo 'CMake arguments: ${{ matrix.cmake_args }}'
102+
echo 'CMake target: ${{ matrix.cmake_target }}'
103+
echo 'Config name: ${{ matrix.config_name }}'
91104
- name: Clean workspace (MacOS)
92105
if: ${{ inputs.os == 'macos' }}
93106
run: |

0 commit comments

Comments
 (0)