Skip to content

Commit 8338a31

Browse files
a1q123456a1q123456
committed
Optimisation
Signed-off-by: JCW <[email protected]>
1 parent bf7fcf3 commit 8338a31

File tree

12 files changed

+39
-39
lines changed

12 files changed

+39
-39
lines changed

‎include/xrpl/basics/Log.h‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,11 +68,11 @@ class Logs
6868
operator=(Sink const&) = delete;
6969

7070
void
71-
write(beast::severities::Severity level, std::string const& text)
71+
write(beast::severities::Severity level, std::string&& text)
7272
override;
7373

7474
void
75-
writeAlways(beast::severities::Severity level, std::string const& text)
75+
writeAlways(beast::severities::Severity level, std::string&& text)
7676
override;
7777
};
7878

‎include/xrpl/beast/utility/Journal.h‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ class Journal
225225
severities::Severity severity) const;
226226

227227
static std::string
228-
formatLog(std::string const& message);
228+
formatLog(std::string&& message);
229229

230230
public:
231231
//--------------------------------------------------------------------------
@@ -279,7 +279,7 @@ class Journal
279279
level is below the current threshold().
280280
*/
281281
virtual void
282-
write(Severity level, std::string const& text) = 0;
282+
write(Severity level, std::string&& text) = 0;
283283

284284
/** Bypass filter and write text to the sink at the specified severity.
285285
* Always write the message, but maintain the same formatting as if
@@ -289,7 +289,7 @@ class Journal
289289
* @param text Text to write to sink.
290290
*/
291291
virtual void
292-
writeAlways(Severity level, std::string const& text) = 0;
292+
writeAlways(Severity level, std::string&& text) = 0;
293293

294294
private:
295295
Severity thresh_;

‎include/xrpl/beast/utility/WrappedSink.h‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,14 +88,14 @@ class WrappedSink : public beast::Journal::Sink
8888
}
8989

9090
void
91-
write(beast::severities::Severity level, std::string const& text) override
91+
write(beast::severities::Severity level, std::string&& text) override
9292
{
9393
using beast::Journal;
9494
sink_.write(level, prefix_ + text);
9595
}
9696

9797
void
98-
writeAlways(severities::Severity level, std::string const& text) override
98+
writeAlways(severities::Severity level, std::string&& text) override
9999
{
100100
using beast::Journal;
101101
sink_.writeAlways(level, prefix_ + text);

‎src/libxrpl/basics/Log.cpp‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,20 +47,20 @@ Logs::Sink::Sink(
4747
}
4848

4949
void
50-
Logs::Sink::write(beast::severities::Severity level, std::string const& text)
50+
Logs::Sink::write(beast::severities::Severity level, std::string&& text)
5151
{
5252
if (level < threshold())
5353
return;
5454

55-
logs_.write(level, partition_, text, console());
55+
logs_.write(level, partition_, std::move(text), console());
5656
}
5757

5858
void
5959
Logs::Sink::writeAlways(
6060
beast::severities::Severity level,
61-
std::string const& text)
61+
std::string&& text)
6262
{
63-
logs_.write(level, partition_, text, console());
63+
logs_.write(level, partition_, std::move(text), console());
6464
}
6565

6666
//------------------------------------------------------------------------------

‎src/libxrpl/beast/utility/beast_Journal.cpp‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -77,12 +77,12 @@ class NullJournalSink : public Journal::Sink
7777
}
7878

7979
void
80-
write(severities::Severity, std::string const&) override
80+
write(severities::Severity, std::string&&) override
8181
{
8282
}
8383

8484
void
85-
writeAlways(severities::Severity, std::string const&) override
85+
writeAlways(severities::Severity, std::string&&) override
8686
{
8787
}
8888
};
@@ -264,7 +264,7 @@ Journal::initMessageContext(
264264
}
265265

266266
std::string
267-
Journal::formatLog(std::string const& message)
267+
Journal::formatLog(std::string&& message)
268268
{
269269
if (!m_jsonLogsEnabled)
270270
{
@@ -363,13 +363,13 @@ Journal::ScopedStream::ScopedStream(
363363

364364
Journal::ScopedStream::~ScopedStream()
365365
{
366-
std::string const& s(m_ostream.str());
366+
std::string s(m_ostream.str());
367367
if (!s.empty())
368368
{
369369
if (s == "\n")
370370
m_sink.write(m_level, formatLog(""));
371371
else
372-
m_sink.write(m_level, formatLog(s));
372+
m_sink.write(m_level, formatLog(std::move(s)));
373373
}
374374
}
375375

‎src/test/beast/beast_Journal_test.cpp‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,14 +48,14 @@ class Journal_test : public unit_test::suite
4848
}
4949

5050
void
51-
write(severities::Severity level, std::string const&) override
51+
write(severities::Severity level, std::string&&) override
5252
{
5353
if (level >= threshold())
5454
++m_count;
5555
}
5656

5757
void
58-
writeAlways(severities::Severity level, std::string const&) override
58+
writeAlways(severities::Severity level, std::string&&) override
5959
{
6060
++m_count;
6161
}

‎src/test/csf/Sim.h‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ class BasicSink : public beast::Journal::Sink
4949
}
5050

5151
void
52-
write(beast::severities::Severity level, std::string const& text) override
52+
write(beast::severities::Severity level, std::string&& text) override
5353
{
5454
if (level < threshold())
5555
return;
@@ -59,7 +59,7 @@ class BasicSink : public beast::Journal::Sink
5959
}
6060

6161
void
62-
writeAlways(beast::severities::Severity level, std::string const& text)
62+
writeAlways(beast::severities::Severity level, std::string&& text)
6363
override
6464
{
6565
std::cout << clock_.now().time_since_epoch().count() << " " << text

‎src/test/jtx/CaptureLogs.h‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,15 +57,15 @@ class CaptureLogs : public Logs
5757
}
5858

5959
void
60-
write(beast::severities::Severity level, std::string const& text)
60+
write(beast::severities::Severity level, std::string&& text)
6161
override
6262
{
6363
std::lock_guard lock(strmMutex_);
6464
strm_ << text;
6565
}
6666

6767
void
68-
writeAlways(beast::severities::Severity level, std::string const& text)
68+
writeAlways(beast::severities::Severity level, std::string&& text)
6969
override
7070
{
7171
std::lock_guard lock(strmMutex_);

‎src/test/jtx/CheckMessageLogs.h‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,18 +45,18 @@ class CheckMessageLogs : public Logs
4545
}
4646

4747
void
48-
write(beast::severities::Severity level, std::string const& text)
48+
write(beast::severities::Severity level, std::string&& text)
4949
override
5050
{
5151
if (text.find(owner_.msg_) != std::string::npos)
5252
*owner_.pFound_ = true;
5353
}
5454

5555
void
56-
writeAlways(beast::severities::Severity level, std::string const& text)
56+
writeAlways(beast::severities::Severity level, std::string&& text)
5757
override
5858
{
59-
write(level, text);
59+
write(level, std::move(text));
6060
}
6161
};
6262

‎src/test/server/Server_test.cpp‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ class Server_test : public beast::unit_test::suite
8989
}
9090

9191
void
92-
write(beast::severities::Severity level, std::string const& text)
92+
write(beast::severities::Severity level, std::string&& text)
9393
override
9494
{
9595
if (level < threshold())
@@ -99,7 +99,7 @@ class Server_test : public beast::unit_test::suite
9999
}
100100

101101
void
102-
writeAlways(beast::severities::Severity level, std::string const& text)
102+
writeAlways(beast::severities::Severity level, std::string&& text)
103103
override
104104
{
105105
suite_.log << text << std::endl;

0 commit comments

Comments
 (0)